chore: Clear up deprecations through the code base #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a few minor fixes that are inconsequential.
Replaces `approxEqual` with `isClose` and add `pure` to `doubleValue` as it was otherwise failing to compile. As void initialization of bool is no longer safe, this led to two other minor code adjustments.
Geod24
force-pushed
the
mlang/Deprecations
branch
from
4d801a4 to
87373fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
approxEqualwithisCloseand addpuretodoubleValueas it was otherwise failing to compile. As void initialization of bool is no longer safe, this led to two other minor code adjustments.