Skip to content

Conversation

@phkrl
Copy link

@phkrl phkrl commented Dec 27, 2024

This pull requests is intended to close #1140
libvirt_domain vcpu field is made into block, where count is old vcpu count and placement and cpusets are also configured. As a result, specifying the latter fields allow to run libvirt domains on aarch64 SoCs with different cores via this provider. Further testing is required, however, to check other platforms still work as intended.
Note: i cannot confirm that acceptance tests are working. On aarch64 they also fail for me in current main branch.
I'll update documentation to this PR once the schema and functionality are confirmed and approved by maintainers.

supported attributes:
 count for vpus count (replaces vcpus format used previously)
 placement - auto or static
 spuset - allows binding to specific cores on host
@dmacvicar dmacvicar changed the base branch from main to v0.8 November 8, 2025 00:12
@dmacvicar
Copy link
Owner

ℹ️ ℹ️ ℹ️ ℹ️ ℹ️ ℹ️

This contribution is relevant to the legacy version of the provider, which is now in the v0.8 branch of this repository.

Future development is based on a new provider, which is not compatible with this one, nor does share code.

As the new provider solves many issues with the legacy, and to make development in my free time more enjoyable, I have decided to close all PRs for the legacy provider, and to ask to check if the contribution would apply to the new one. This also to encourage trying the new version.

and check the documentation:

You are free to reopen the PR for v0.8, which is targetted now to the v0.8 branch. We may also start a discussion if we can assemble a team of maintainters for the legacy branch. My efforts will go into the new provider.

I ask you to check the new provider and re-evaluate this contribution. 🙏

@dmacvicar dmacvicar closed this Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling vcpu cpuset parameter for heterogeneous cpus

2 participants