fix: support domain name lookup when ID is not a UUID #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow resourceLibvirtDomainRead to handle both UUID and domain name IDs. This fixes crashes when domains are imported by name instead of UUID. When a domain is imported using terraform import with a domain name (e.g., 'docker-engine-1'), the resource ID is set to the domain name. However, the read function was always trying to parse the ID as a UUID and call DomainLookupByUUID, which caused a panic for non-UUID strings. This change: - First attempts to parse the ID as a UUID - Falls back to DomainLookupByName if UUID parsing fails - Updates the resource ID to use the UUID for consistency - Maintains backward compatibility with existing UUID-based IDs Fixes issues where 'terraform import' with domain names would cause provider crashes during subsequent read operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow resourceLibvirtDomainRead to handle both UUID and domain name IDs. This fixes crashes when domains are imported by name instead of UUID.
When a domain is imported using terraform import with a domain name, the resource ID is set to the domain name. However, the read function was always trying to parse the ID as a UUID, which caused panics.
This change falls back to DomainLookupByName if UUID parsing fails and maintains backward compatibility.