Skip to content

fix: Process hypervisor fileds witout xml tags #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Process hypervisor fileds witout xml tags #1223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions internal/codegen/parser/libvirtxml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,25 @@ func (r *LibvirtXMLReflector) analyzeField(structName string, field reflect.Stru

xmlTag := field.Tag.Get("xml")
if xmlTag == "" {
// Skip fields without XML tags
return nil, nil
// Handle hypervisor-specific fields that are missing XML tags.
hypervisorPrefixes := []string{"QEMU", "LXC", "BHyve", "VMWare", "Xen"}
var guessedTag string

for _, prefix := range hypervisorPrefixes {
if strings.HasPrefix(field.Name, prefix) {
namespace := strings.ToLower(prefix)
element := strings.ToLower(strings.TrimPrefix(field.Name, prefix))
guessedTag = fmt.Sprintf("%s:%s,omitempty", namespace, element)
break
}
}

if guessedTag != "" {
xmlTag = guessedTag
} else {
// If it's not a known hypervisor field, skip it as before.
return nil, nil
}
}

isDashTag := xmlTag == "-"
Expand Down