Mark string methods as public. #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix the associated tests. Apparently printing to stdout caused them to fail ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two string helpers (to_string and format_uuid) were not marked "pub", and therefore couldn't be called on an UUID created outside the module.
Since these method aren't called anywhere inside the struct, and looking at the test, I assume this is not the intended behavior.
I'm fairly new to zig, so maybe this broke in a recent release (I'm using 0.11.0) ?
Also, the associated tests were failing, which seemed to be caused by writing to stdout. Using
std.loginstead ofstd.debug.printseems to fix the issue.