Skip to content

Conversation

@dmurvihill
Copy link
Owner

Reopening the original PR here.

@dmurvihill
Copy link
Owner Author

Tagging @joelpoloney as he expressed interest in this change.

Copy link
Owner Author

@dmurvihill dmurvihill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally left feedback on the other PR.

Copy link
Owner Author

@dmurvihill dmurvihill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to punt the issue of admin versus regular SDK to version 4. Merging.

# Conflicts:
#	test/unit/firestore-collection.js
@dmurvihill dmurvihill merged commit ee51273 into master Jan 13, 2020
@dmurvihill dmurvihill deleted the list-documents branch January 13, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants