Add user json #36
Merged
Add user json #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurvihill
commented
Nov 20, 2019
| }); | ||
| }; | ||
|
|
||
| MockFirebaseUser.prototype.toJSON = function() { |
There was a problem hiding this comment.
This definitely would be useful. Anyone willing to write us some tests?
dmurvihill
force-pushed
the
add-user-json
branch
from
a95bafe to
3f4c2cc
Compare
|
Updated to reflect Firebase 5+ and added tests, but not all keys are mocked here. |
# Conflicts: # src/user.js
|
Merged. Thanks @joshAg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the original PR here.