crash fix when using a custom dmp_path regex #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2019 10:21
- This prevents a crash if the dmp_path regex captures a None value for the dmp_urlparams matching group. A regex like: ^(org\.(?P<orgslug>[_a-zA-Z0-9\-]+)/)?(?P<dmp_page>[_a-zA-Z0-9\-]+)(\.?P<dmp_function>[_a-zA-Z0-9\.\-]+)?/(?P<dmp_urlparams>.+?)?$ for a path like: org.agency-1/agent_dashboard/ would result in the crash.
- This avoids silent errors when a view has a syntax error or other failure that causes it to not import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the dmp_urlparams matching group. A regex like:
^(org.(?P[_a-zA-Z0-9-]+)/)?(?P<dmp_page>[_a-zA-Z0-9-]+)(.?P<dmp_function>[_a-zA-Z0-9.-]+)?/(?P<dmp_urlparams>.+?)?$
for a path like:
org.agency-1/agent_dashboard/
would result in the crash.