[Release]: v4.12.1

docs/README.md

@@ -35,4 +35,4 @@ Users and the development team are usually in the [Discord server](https://disco
 
 _Vercel_ has given us a Pro account.
 
-<a href="https://vercel.com/?utm_source=docsifyjsdocs" target="_blank"><img src="_media/vercel_logo.svg" width="100px"></a>
+<a href="https://vercel.com/?utm_source=docsifyjsdocs" target="_blank"><img src="https://cdn.jsdelivr.net/gh/docsifyjs/docsify/docs/_media/vercel_logo.svg" width="100px"></a>

docs/configuration.md

@@ -354,7 +354,7 @@ Set the route alias. You can freely manage routing rules. Supports RegExp.
 ```js
 window.$docsify = {
   alias: {
-    '/foo/(+*)': '/bar/$1', // supports regexp
+    '/foo/(.*)': '/bar/$1', // supports regexp
     '/zh-cn/changelog': '/changelog',
     '/changelog':
       'https://raw.githubusercontent.com/docsifyjs/docsify/master/CHANGELOG',

docs/index.html

@@ -196,7 +196,7 @@
                 }
                 return (
                   html +
-                  '<br/> <i>Vercel</i> has given us a Pro account <br/> <a href="https://vercel.com/?utm_source=docsifyjsdocs" target="_blank"><img src="_media/vercel_logo.svg" alt="Vercel" width="100" height="64"></a>'
+                  '<br/> <i>Vercel</i> has given us a Pro account <br/> <a href="https://vercel.com/?utm_source=docsifyjsdocs" target="_blank"><img src="https://cdn.jsdelivr.net/gh/docsifyjs/docsify/docs/_media/vercel_logo.svg" alt="Vercel" width="100" height="64"></a>'
                 );
               });
           },

packages/docsify-server-renderer/package.json

@@ -16,7 +16,7 @@
   },
   "dependencies": {
     "debug": "^4.3.2",
-    "docsify": "^4.11.6",
+    "docsify": "^4.12.0",
     "dompurify": "^2.2.6",
     "node-fetch": "^2.6.0",
     "resolve-pathname": "^3.0.0"

src/core/fetch/index.js

@@ -1,7 +1,7 @@
 /* eslint-disable no-unused-vars */
 import { callHook } from '../init/lifecycle';
 import { getParentPath, stringifyQuery } from '../router/util';
-import { noop } from '../util/core';
+import { noop, isExternal } from '../util/core';
 import { getAndActive } from '../event/sidebar';
 import { get } from './ajax';
 
@@ -20,32 +20,6 @@ function loadNested(path, qs, file, next, vm, first) {
   ).then(next, _ => loadNested(path, qs, file, next, vm));
 }
 
-function isExternal(url) {
-  let match = url.match(
-    /^([^:/?#]+:)?(?:\/\/([^/?#]*))?([^?#]+)?(\?[^#]*)?(#.*)?/
-  );
-  if (
-    typeof match[1] === 'string' &&
-    match[1].length > 0 &&
-    match[1].toLowerCase() !== location.protocol
-  ) {
-    return true;
-  }
-  if (
-    typeof match[2] === 'string' &&
-    match[2].length > 0 &&
-    match[2].replace(
-      new RegExp(
-        ':(' + { 'http:': 80, 'https:': 443 }[location.protocol] + ')?$'
-      ),
-      ''
-    ) !== location.host
-  ) {
-    return true;
-  }
-  return false;
-}
-
 export function fetchMixin(proto) {
   let last;
 

src/core/util/core.js

@@ -66,3 +66,35 @@ export function noop() {}
 export function isFn(obj) {
   return typeof obj === 'function';
 }
+
+/**
+ * Check if url is external
+ * @param {String} string  url
+ * @returns {Boolean} True if the passed-in url is external
+ */
+export function isExternal(url) {
+  let match = url.match(
+    /^([^:/?#]+:)?(?:\/{2,}([^/?#]*))?([^?#]+)?(\?[^#]*)?(#.*)?/
+  );
+
+  if (
+    typeof match[1] === 'string' &&
+    match[1].length > 0 &&
+    match[1].toLowerCase() !== location.protocol
+  ) {
+    return true;
+  }
+  if (
+    typeof match[2] === 'string' &&
+    match[2].length > 0 &&
+    match[2].replace(
+      new RegExp(
+        ':(' + { 'http:': 80, 'https:': 443 }[location.protocol] + ')?$'
+      ),
+      ''
+    ) !== location.host
+  ) {
+    return true;
+  }
+  return false;
+}

test/e2e/security.test.js

@@ -0,0 +1,32 @@
+const docsifyInit = require('../helpers/docsify-init');
+
+describe(`Security`, function() {
+  const sharedOptions = {
+    markdown: {
+      homepage: '# Hello World',
+    },
+    routes: {
+      'test.md': '# Test Page',
+    },
+  };
+
+  describe(`Cross Site Scripting (XSS)`, function() {
+    const slashStrings = ['//', '///'];
+
+    for (const slashString of slashStrings) {
+      const hash = `#${slashString}domain.com/file.md`;
+
+      test(`should not load remote content from hash (${hash})`, async () => {
+        await docsifyInit(sharedOptions);
+        await expect(page).toHaveText('#main', 'Hello World');
+        await page.evaluate(() => (location.hash = '#/test'));
+        await expect(page).toHaveText('#main', 'Test Page');
+        await page.evaluate(newHash => {
+          location.hash = newHash;
+        }, hash);
+        await expect(page).toHaveText('#main', 'Hello World');
+        expect(page.url()).toMatch(/#\/$/);
+      });
+    }
+  });
+});

test/unit/core-util.test.js

@@ -0,0 +1,63 @@
+const { isExternal } = require('../../src/core/util');
+
+// Core util
+// -----------------------------------------------------------------------------
+describe('core/util', () => {
+  // isExternal()
+  // ---------------------------------------------------------------------------
+  describe('isExternal()', () => {
+    // cases non external
+    test('non external local url with one /', () => {
+      const result = isExternal(`/${location.host}/docsify/demo.md`);
+
+      expect(result).toBeFalsy();
+    });
+
+    test('non external local url with two //', () => {
+      const result = isExternal(`//${location.host}/docsify/demo.md`);
+
+      expect(result).toBeFalsy();
+    });
+
+    test('non external local url with three ///', () => {
+      const result = isExternal(`///${location.host}/docsify/demo.md`);
+
+      expect(result).toBeFalsy();
+    });
+
+    test('non external local url with more /', () => {
+      const result = isExternal(
+        `//////////////////${location.host}/docsify/demo.md`
+      );
+
+      expect(result).toBeFalsy();
+    });
+
+    test('non external url with one /', () => {
+      const result = isExternal('/example.github.io/docsify/demo.md');
+
+      expect(result).toBeFalsy();
+    });
+
+    // cases is external
+    test('external url with two //', () => {
+      const result = isExternal('/docsify/demo.md');
+
+      expect(result).toBeFalsy();
+    });
+
+    test('external url with three ///', () => {
+      const result = isExternal('///example.github.io/docsify/demo.md');
+
+      expect(result).toBeTruthy();
+    });
+
+    test('external url with more /', () => {
+      const result = isExternal(
+        '//////////////////example.github.io/docsify/demo.md'
+      );
+
+      expect(result).toBeTruthy();
+    });
+  });
+});