Code path to check for and abort if doc.domain is blacklisted #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added an entry field to the preferences. Each line represents a regex that will be applied against doc.domain. If the regex matches, IAT will abort.
docwhat
requested changes
Oct 5, 2016
Owner
docwhat
left a comment
docwhat
left a comment
There was a problem hiding this comment.
It might be nice to include an example RegExp or something in there. Like .*example\.com$ or something harmless.
|
|
||
| var blacklisted_domains = itsalltext.preferences.blacklist_domains.split("\n"); | ||
| var pattern, | ||
| domain_is_blacklisted = false; |
Owner
There was a problem hiding this comment.
Can you make this a separate method? And it should probably be called something like isDomainBlacklisted() take a domain as a string.
In theory, I should be writing tests for this stuff, but it wasn't really a thing when I started this project.
| } | ||
|
|
||
| /* | ||
| var console = Cc["@mozilla.org/consoleservice;1"].getService(Ci.nsIConsoleService); |
Owner
There was a problem hiding this comment.
You can use the built-in IAT debugging stuff... there are examples around here someplace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an entry field to the preferences. Each line represents a
regex that will be applied against doc.domain. If the regex matches,
IAT will abort.