Skip to content

Conversation

yanky2000
Copy link
Contributor

@yanky2000 yanky2000 commented Sep 30, 2025

Description

Added ts file ext to the codegen config to match the example in the docs.
In the docs example the query is placed in the "index.ts" file. This update will allow the query get the type correctly and ts will now compile correctly

Related # (issue)

issue

Type of change

  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Screenshot 2025-09-30 at 16 08 39

How Has This Been Tested?

Screenshot 2025-09-30 at 16 04 30

Test Environment:

  • OS: macos
  • @graphql-codegen/...:
  • NodeJS: 23.7.0

Checklist:

  • [ x ] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

added ts file ext to match the example.
the query is written in the "index.ts" file.
wo this the query in the example doesn't get the type correctly and ts doesn't compile correctly
Copy link

changeset-bot bot commented Sep 30, 2025

⚠️ No Changeset found

Latest commit: 1a53f24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eddeee888 eddeee888 merged commit 9f6ccb1 into dotansimha:master Oct 5, 2025
@eddeee888
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants