[DRAFT] Move ActiveDirectoryAuthenticationProvider Tests #3717

paulmedynski · 2025-10-24T13:53:46Z

Description

This PR moves all existing MDS tests that use the ActiveDirectoryAuthenticationProvider (ADAP) into the Azure project. The tests are moved as-is with non-functional changes to get them to build/run.

A few MDS tests were unnecessarily using ADAP when they should have been using a test provider, so I updated them to do so.

A full suite of tests for the Azure package will be created in future PRs.

Testing

Existing CI for the Azure and MDS packages should confirm everything.

- Removed addition of PDBs from <AllowedOutputExtensionsInPackageBuildOutputFolder>. - Removed MDS package ref dependency on Abstractions until pipelines are ready. - Renamed AbstractionsPackage to Abstractions in targets. - Updated BUILDGUIDE based on project ref behaviour. - Added feature branches to CI pipeline triggers. - Added missing/incomplete paths to the trigger. - Added dev/* branches to the CI triggers so PRs that target other dev/ branches can run CI. - Added missing MdsPackageVersion property to signed build pipeline job. - Commented-out failing NuGet tool installer task. - Re-ordered Guardian analysis step _before_ build step to avoid clobbering versioned DLLs. - Added MDS package version to AKV build/package steps. - Restored AKV nuspec ReferenceType property for AKV Official builds. - Explicitly building tooling before analysis. - Fixing validation steps to match XML props files. - Added PR automation triggers, and documented other pipeline sections. - Added ReferenceType throughout the MDS/AKV CI build steps. - Added NuGet.config update to main CI build step for Package reference mode. - Swapped Abstractions download and NuGet.config update to ensure packages/ exists before attempting to re-configure NuGet. - Clean target no longer removes packages/ - Uncommented package refs to Abstractions. - Added separate MDS and AKV project builds to support Package mode. - Added $ReferenceType$ property to MDS .nuspec like it is for AKV. - Removed obsolete version variables from merge conflict. - Adding $ReferenceType$ back to AKV nuspec. - Moved SqlAuthenticationProvider and friends into Abstractions. - Moved ActiveDirectoryAuthenticationProvider into a new Azure package. - Moved a bunch of docs into Abstractions and Azure projects. - Updated Abstractions classes to be abstract with minimal implementation. - Added back the implementations to MDS. - Re-worked some of the docs. - SqlAuthentication* classes separated out into Base classes in Abstractions. - Updated docs accordingly. - MDS compiles. - Some Azure package code moved, but not compiling. - Added an exception class for authentication errors. - Enabled XML doc compilation and validation. - Updated MDS to handle SqlAuthenticationProviderException instead of MSAL exceptions. - Removed Azure.Identity from MDS. - Got existing tests compiling using the new Azure package. - Added Azure package build targets. - Updated docs related to ReferenceType - Got all projects properly adhering to Package reference type. - Removed TestMicrosoftDataSqlClientVersion in favour of MdsPackageVersion. - Fixed tools restore from build.proj. - Fixed missing using for dummy auth provider. - Fixed obsolete warnings for password auth. - Moved SqlAuthenticationParameters entirely into Abstractions, avoiding an empty base class. - Moved SqlAuthenticationToken entirely into Abstractions. - Moved SqlAuthenticationProvider entirely into Abstractions. - Removed SqlAuthenticationProviderBase. - Exposed SqlAuthenticationProviderManager as a public API in MDS. - Moved SetProvider() and GetProvider() to the Manager where they should have been all along (Breaking Change). - Added catch-all exception handlers in prep for proper analysis and specific exception handling. - Some improvements to avoid meaningless nulls. - Added PR/CI pipeline support for the Azure package. - Fixed Abstractions download path. - Updated SqlAuthenticationProviderException to use Method instead of Action. - Fixed NRE in SqlException. - Fixed SqlAuthenticationProviderException use in MDS. - Added chaining Add() to SqlErrorCollection. - Added a useful message when _fedAuthToken is null after attempting to acquire a token. - Fixed auth provider error handling to mimic the old code. - Removing unnecessary database checks that are hanging forever. - Fixed timestamp truncation from long to uint causing cached tokens to be erroneously expired.

…r to maintain API for now. - Addressed review comments.

- Added some config improvements to xUnit runners.

…qlClient-Package runs.

…eaved output.

…g interleaved output." This reverts commit 807bfa7.

…ith CI-SqlClient-Package runs." This reverts commit d4c681a.

- Reverted SqlAuthenticationParameters authenticationTimeout constructor argument to its original name connectionTimeout and added docs explaining why.

paulmedynski

Commentary for reviewers.

paulmedynski · 2025-10-24T13:58:11Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/SqlAuthenticationProviderTest.cs

+    #pragma warning disable 0618 // Type or member is obsolete
+    [InlineData(SqlAuthenticationMethod.ActiveDirectoryPassword)]
+    #pragma warning restore 0618 // Type or member is obsolete
+    [InlineData(SqlAuthenticationMethod.ActiveDirectoryInteractive)]


Interactive was missing from the original test, so I added it here.

paulmedynski · 2025-10-24T14:02:06Z

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

 namespace Microsoft.Data.SqlClient.ManualTesting.Tests
 {
-    public class AADConnectionsTest
+    public class AADConnectionTest


The test class name didn't match the filename.

paulmedynski · 2025-10-24T14:03:24Z

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

-            // Clear token cache for code coverage.
-            ActiveDirectoryAuthenticationProvider.ClearUserTokenCache();
-            using (SqlConnection connection = new SqlConnection(DataTestUtility.AADPasswordConnectionString))
+            #pragma warning disable 0618 // Type or member is obsolete


These tests were unnecessarily using our auth provider, so I updated them to use the test provider defined above, which fetches real tokens via MSAL itself.

- Moved some tests around to get access to internals and to compile everywhere.

codecov · 2025-10-29T13:20:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.63%. Comparing base (87497dc) to head (1e27ff4).

Additional details and impacted files

@@                           Coverage Diff                           @@
##           dev/paul/azure-split/authentication    #3717      +/-   ##
=======================================================================
- Coverage                                76.78%   76.63%   -0.16%     
=======================================================================
  Files                                      269      263       -6     
  Lines                                    45029    44713     -316     
=======================================================================
- Hits                                     34574    34264     -310     
+ Misses                                   10455    10449       -6

Flag	Coverage Δ
addons	`?`
netcore	`76.63% <ø> (+<0.01%)`	⬆️
netfx	`76.04% <ø> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski

Commentary for reviewers.

paulmedynski · 2025-10-29T13:15:30Z

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/AADConnectionTest.cs

-    public class AADConnectionsTest
+    public class AADConnectionTest
    {
-        class CustomSqlAuthenticationProvider : SqlAuthenticationProvider


Moved this to UsernamePasswordProvider.cs so it could be shared.

paulmedynski · 2025-10-29T13:26:11Z

eng/pipelines/jobs/pack-azure-package-ci-job.yml

-          --verbosity ${{ parameters.verbosity }}
+          --verbosity ${{ parameters.dotnetVerbosity }}
          -p:ReferenceType=${{ parameters.referenceType }}
+          -p:ForceMdsAssemblyNameSuffix=true


This is explained in my comments on Directory.Build.props.

paulmedynski · 2025-10-29T13:27:36Z

eng/pipelines/stages/stress-tests-ci-stage.yml

-  # to stress test.
-  - name: pipelineArtifactName
-    displayName: Pipeline Artifact Name
+  # The verbosity level for the dotnet CLI commands.


Sorted parameters alphabetically and added some debug/verbosity.

paulmedynski · 2025-10-29T13:28:55Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

+      Apply an MDS assembly name suffix, if necessary.  See the top-level
+      Directory.Build.props for more information.
+    -->
+    <DefineConstants Condition="'$(ApplyMdsAssemblyNameSuffix)' == 'true'">$(DefineConstants);APPLY_MDS_ASSEMBLY_NAME_SUFFIX</DefineConstants>


Abstractions performs reflection against the MDS assembly, so it needs to know how to form the assembly name. Explained in Directory.Build.props.

paulmedynski · 2025-10-29T13:33:22Z

src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj

+      Append an assembly name suffix, if necessary.  See the top-level
+      Directory.Build.props for more information.
+    -->
+    <AssemblyName>Microsoft.Data.SqlClient</AssemblyName>


The 2 ref projects didn't previously specify <AssemblyName>. Not sure why, or if this new addition will cause problems. Thoughts?

paulmedynski · 2025-10-29T13:34:40Z

...crosoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.FunctionalTests.csproj

    <ProjectReference
      Condition="'$(TargetGroup)'=='netfx'"
      Include="$(NetFxSource)src\Microsoft.Data.SqlClient.csproj" />
-    <ProjectReference Include="../../../Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj" />


This ensures that none of the Functional (or Manual) tests are depending on our auth provider by accident.

paulmedynski · 2025-10-29T13:35:45Z

src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs

+            //
+            // TODO: Figure out which ones and install on-demand rather than
+            // globally.
+            SqlAuthenticationProvider.SetProvider(


This entire test suite is now serviced either by this provider, or by the UsernamePasswordProvider on-demand.

No other auth methods have a provider installed.

paulmedynski · 2025-10-29T13:38:14Z

...ata.SqlClient/tests/ManualTests/SQL/AADFedAuthTokenRefreshTest/AADFedAuthTokenRefreshTest.cs

            }
+            finally
+            {
+                if (original is not null)


For some reason there is no unset-provider mechanism, so we're polluting the global scope in the event that no provider was registered before this test.

You will see this pattern elsewhere as well. SetProvider() throws an NRE if you pass null.

paulmedynski · 2025-10-29T13:41:40Z

tools/specs/Microsoft.Data.SqlClient.nuspec

      <group targetFramework="net462">
-        <reference file="Microsoft.Data.SqlClient.dll" />
-        <reference file="Microsoft.Data.SqlClient.xml" />
+        <reference file="Microsoft.Data.SqlClient$AssemblyNameSuffixNetFx$.dll" />


Our project-reference based builds probably shouldn't be attempting to generate NuGet packages, but since they do, I made it work. The generated packages aren't used for anything (see CI-SqlClient pipeline), so there is no harm here.

As mentioned in the Directory.Build.props commentary, this is all temporary code anyway and should disappear before 7.0.0 GA.

paulmedynski · 2025-10-29T13:45:39Z

src/Directory.Build.props

+      project to determine whether or not to apply the MDS assembly name suffix.
+    -->
+    <ApplyMdsAssemblyNameSuffix>false</ApplyMdsAssemblyNameSuffix>
+    <ApplyMdsAssemblyNameSuffix


This is a temporary measure to get the Abstractions and Azure projects (and their tests) to build without having to employ the confusing tricks found in the FunctionalTests, ManualTests, and AKV projects, where we only support building for one type of framework at a time (ick!). This will all disappear when we finally complete the .NET and .NET Framework codebase merge, and we have a single MDS project.

Single assembly?

Removed that part since it was confusing. We will produce the same number of MDS assembly files (DLLs), but will no longer be prevented from building them all at once via project references due to multiple projects specifying the same assembly name.

- Added XML docs throughout. - Improved unit test names. - Removed <RootNamespace> from project files. - Removed unnecessary sample files from the Abstractions project.

- Moved existing tests that use ActiveDirectoryAuthenticationProvider into Azure tests. - Updated some MDS tests that unnecessarily used ActiveDirectoryAuthenticationProvider. - Fixed project-based builds so we can restore MDS netcore and netfx projects at the same time. - Added a Managed Identity provider that is installed by default for the Manual Tests suite. - Moved some tests from ManualTests to Azure that require the provider. - Avoiding calling SetProvider with a null value, since it isn't possible to unset a provider once set. - Added caching to the managed identity provider for the ManualTest project. - Added environment variable debug logging to Abstractions and Azure pipeline jobs. - Moved username/password Entra auth provider into its own file for sharing across tests. - Added ADO service connection for test tasks that require access to Azure resources. - Added workload identity federation tests. - Disabling xUnit shadow copy to prevent strong name varification failures. - Modified tests moved from ManualTests to compile using the new Config helper. - Injecting config into pipeline runs via the config.json approach. - Simplified TestUtilities project. - Added ADO CI pool condition to some tests that require it. - Updated xunit.runner.json config to indicate which options are only available in xUnit v3+. - Fixed exception message check to account for OS differences. - Solved the mystery of SNI DLLs missing for .NET Framework project-reference-based builds. - Added ADO-CI-1ES pool jobs to test the Azure package on Linux and Windows. - Fixed Azure package pipelines to support pools in the ADO.Net and Public projects. - Added some new pipeline variables to handle the Workload Identity Federation test.

paulmedynski added 12 commits October 20, 2025 11:59

Abstractions Package - C# project changes (#3626)

f6a74cc

Abstractions Package - Pipeline Changes (#3628)

c66066a

- Added obsolete Get/Set Provider methods on SqlAuthenticationProvide…

bdd1c13

…r to maintain API for now. - Addressed review comments.

- Fixed dummy auth provider tests on .NET Framework.

522e5a4

- Added some config improvements to xUnit runners.

- Attempt to fix sensitive diagnostics tests having trouble with CI-S…

d4c681a

…qlClient-Package runs.

- Replaced Console output with xUnit output to avoid confusing interl…

807bfa7

…eaved output.

Revert "- Replaced Console output with xUnit output to avoid confusin…

39d2d10

…g interleaved output." This reverts commit 807bfa7.

Revert "- Attempt to fix sensitive diagnostics tests having trouble w…

278c872

…ith CI-SqlClient-Package runs." This reverts commit d4c681a.

Merge branch 'feat/azure-split' into dev/paul/azure-split/authentication

eebd756

- Addressed review comments.

5d5fa84

- Reverted SqlAuthenticationParameters authenticationTimeout constructor argument to its original name connectionTimeout and added docs explaining why.

- Fixed build error related to SqlAuthenticationParameters.

65091f4

paulmedynski added this to the 7.0.0-preview3 milestone Oct 24, 2025

paulmedynski commented Oct 24, 2025

View reviewed changes

paulmedynski added 4 commits October 28, 2025 08:52

- Reverted all public API changes from previous commits.

323cdda

- Moved some tests around to get access to internals and to compile everywhere.

- Removed SqlAuthenticationProviderManager from ref projects.

196edf5

- Fixed incorrect checks for runtime detection.

a2988d3

- Fixed a few missed Manager provider calls.

48e5eb7

paulmedynski force-pushed the dev/paul/azure-split/move-tests branch from 1903ecc to b17155b Compare October 28, 2025 16:27

paulmedynski commented Oct 29, 2025

View reviewed changes

paulmedynski added 2 commits November 7, 2025 10:44

- Addressed review comments:

87497dc

- Added XML docs throughout. - Improved unit test names. - Removed <RootNamespace> from project files. - Removed unnecessary sample files from the Abstractions project.

paulmedynski force-pushed the dev/paul/azure-split/move-tests branch from 5d4f942 to 1e27ff4 Compare November 7, 2025 19:28

paulmedynski changed the title ~~Move ActiveDirectoryAuthenticationProvider Tests~~ [DRAFT] Move ActiveDirectoryAuthenticationProvider Tests Nov 7, 2025

Base automatically changed from dev/paul/azure-split/authentication to feat/azure-split November 14, 2025 20:08

[DRAFT] Move ActiveDirectoryAuthenticationProvider Tests #3717

Are you sure you want to change the base?

[DRAFT] Move ActiveDirectoryAuthenticationProvider Tests #3717

Uh oh!

Conversation

paulmedynski commented Oct 24, 2025

Description

Testing

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paulmedynski Oct 24, 2025 •

edited

Loading

codecov bot commented Oct 29, 2025 •

edited

Loading

paulmedynski Oct 29, 2025 •

edited

Loading

paulmedynski Oct 29, 2025 •

edited

Loading

paulmedynski Oct 29, 2025 •

edited

Loading

paulmedynski Oct 29, 2025 •

edited

Loading

paulmedynski Oct 29, 2025 •

edited

Loading