This repository was archived by the owner on Mar 17, 2021. It is now read-only.
fix lttng being optional #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessArguments now first in Main Script lttng use is now guarded everywhere
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when not having lttng available, the perfcollect script is not usable.
Setting the
-nolttngflag on startup doesn't help, as the usage oflttngwasn't guarded properly in the script.This PR fixes this by first processing arguments and guarding the places where
lttngis used.Also fixes some trailing whitespace. If this disturbs your review append
?w=1to the github URL to ignore.