Skip to content

Update strmreader read2.vb #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Conversation

jontho-microsoft-com
Copy link
Contributor

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream
@jontho-microsoft-com jontho-microsoft-com requested a review from a team as a code owner April 12, 2023 22:48
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jontho-microsoft-com jontho-microsoft-com marked this pull request as draft April 12, 2023 22:48
@learn-build-service-prod
Copy link

Learn Build status updates of commit fe7e847:

✅ Validation status: passed

File Status Preview URL Details
snippets/visualbasic/VS_Snippets_CLR/StrmReader Read2/VB/strmreader read2.vb ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Author: jontho-microsoft-com
Assignees: -
Labels:

area-System.IO, community-contribution

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jontho-microsoft-com !

This PR is a draft, do you want to add something more before merging it?

@jontho-microsoft-com
Copy link
Contributor Author

jontho-microsoft-com commented May 11, 2023 via email

@adamsitnik
Copy link
Member

@jontho-microsoft-com If I were you I would push my changes, create a new PR with all fixes and close the existing draft PRs.

@gewarren gewarren marked this pull request as ready for review October 24, 2024 03:38
@gewarren gewarren enabled auto-merge (squash) October 24, 2024 03:39
@BillWagner BillWagner closed this Jul 29, 2025
auto-merge was automatically disabled July 29, 2025 19:38

Pull request was closed

@BillWagner BillWagner reopened this Jul 29, 2025
@BillWagner BillWagner enabled auto-merge (squash) July 29, 2025 19:38
@BillWagner BillWagner merged commit b12d4be into dotnet:main Jul 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants