-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update strmreader read2.vb #8959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Learn Build status updates of commit fe7e847: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Tagging subscribers to this area: @dotnet/area-system-io Issue Details.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream SummaryDescribe your changes here. Fixes #Issue_Number (if available)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jontho-microsoft-com !
This PR is a draft, do you want to add something more before merging it?
Hi Adam,
Actually, I have several changes I mean to do in a pull, and frankly, I find the explanation of how to work with multiple files as a single file set using the online tool with drafts very confusing. I've got some other related changes I need to make to the docs to make things holistic. My objective is to correct the docs such that they can be used with correct information that doesn't result in more support cases. The fascinating thing is these documentation conflicts have been present since the earliest .NET docs, and it appears I got the purple squirrel scenario of someone working with the ZipArchive classes and their forms of streams.
I've been working with a local git repository for changes, since that's more clear-cut in my mind how that is supposed to work.
Any guidance you can provide me for how to do this in the most efficient/fastest process is greatly welcomed, as I'm certain that we'll have the occasional developer support case in the future where we hit this.
In particular, after I've made the final changes I wish to make in the local git repository, I'd like to:
1. Drop the drafts already there
2. Send over the repo I have (I forgot what the requirements are there)
3. Do the PR and get confirmation ASAP, as I have a requirement to do this while recording labor, and get the associated case closed (internal detail).
Thanks!
Jonathan Thompson
Escalation Engineer
Windows SDK Team
Phone: +1 (425) 722-6428
From: Adam Sitnik ***@***.***>
Sent: Thursday, May 11, 2023 10:06 AM
To: dotnet/dotnet-api-docs ***@***.***>
Cc: Jonathan Thompson ***@***.***>; Mention ***@***.***>
Subject: Re: [dotnet/dotnet-api-docs] Update strmreader read2.vb (PR #8959)
@adamsitnik approved this pull request.
LGTM, thank you @jontho-microsoft-com<https://github.com/jontho-microsoft-com> !
This PR is a draft, do you want to add something more before merging it?
-
Reply to this email directly, view it on GitHub<#8959 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKXW4YKE46O5WN5OJLILY5DXFUL6VANCNFSM6AAAAAAW4JMLGY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@jontho-microsoft-com If I were you I would push my changes, create a new PR with all fixes and close the existing draft PRs. |
Pull request was closed
.NET source code clearly shows Read() may not return a fixed number of characters, but only what's currently available on the stream. ReadBlock returns the stated number of characters and only returns fewer if end of stream
Summary
Describe your changes here.
Fixes #Issue_Number (if available)