Fix type mapping for GETDATE and GETUTCDATE in SqlServer. #36613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Aug 20, 2025
There was a problem hiding this comment.
Shouldn't we do the same for the other functions down below (e.g. DateTimeOffset.UtcNow)?
The fix looks accurate, but I think there's an additional problem here, in that we always translate DateTime.Now to GETDATE() which returns datetime, although we generally map .NET DateTime to the higher-precision datetime2. I opened #36616 to fix (I don't think it's super important).
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Outdated
Show resolved
Hide resolved
roji
reviewed
Aug 20, 2025
test/EFCore.SqlServer.FunctionalTests/Query/AdHocMiscellaneousQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
cincuranet
force-pushed
the
fix-date
branch
2 times, most recently
from
9000196 to
46e9c0c
Compare
I'm still seeing an explicit return type mapping for DateTimeOffset.Now, for not for the DateTimeOffset.UtcNow right under it. |
roji
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36479.
Description
Fixes type mapping for GETDATE and GETUTCDATE in SqlServer, which is especially important when comparing with non-column (i.e. constant).
Customer impact
Generated query is rejected by SQL Server and throws error.
How found
Customer reported on 9.
Regression
No.
Testing
Tests added.
Risk
Low. This is a specific case for only these two functions.