-
Notifications
You must be signed in to change notification settings - Fork 832
Use Azure hosting integrations in Aspire AI Chat Web template #6659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks clean to me, @MackinnonBuck. I presume you're seeking some feedback from folks with Aspire expertise; beyond that, what input/feedback/testing would be helpful for you on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the AI Chat Web project template to use Aspire Azure hosting integrations instead of manual connection string configuration. This modernizes the template to leverage automatic Azure resource provisioning capabilities.
- Replaces manual connection string configuration with Azure hosting integrations
- Updates multiple package versions to latest compatible releases
- Simplifies configuration process by using local provisioning patterns
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
File | Description |
---|---|
GeneratedContent.targets | Updates package version properties for Aspire, Azure, and Semantic Kernel dependencies |
Various .csproj files | Bumps package versions and adds new Azure.AI.OpenAI dependency |
Program.cs files | Replaces connection string usage with Azure hosting integration methods |
README.md files | Updates configuration instructions to use local provisioning instead of manual setup |
Comments suppressed due to low confidence (1)
Thanks @jeffhandley - If others are interesting in trying out the new Aspire + Azure OpenAI + Azure AI search template, that would be helpful to validate that I didn't miss any steps in the README. But I would say additional testing isn't a hard requirement before the PR merges; I was able to manually validate the changes myself 🙂 |
cc @eerhardt, @JamesNK, @davidfowl - I would appreciate getting some eyes on the Aspire-related changes 🙂 |
Update to 9.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping to 9.4 makes sense before merge, but otherwise this looks great, @MackinnonBuck.
@sebastienros can you review this ? |
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
....Extensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.AppHost/Program.cs
Show resolved
Hide resolved
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Show resolved
Hide resolved
/backport to release/9.8 |
Started backporting to release/9.8: https://github.com/dotnet/extensions/actions/runs/16915159510 |
@MackinnonBuck backporting to "release/9.8" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Use hosting integrations
Applying: Update README
Applying: Update to Aspire 9.4
Applying: Update snapshots
error: sha1 information is lacking or useless (test/ProjectTemplates/Microsoft.Extensions.AI.Templates.IntegrationTests/Snapshots/aichatweb.AzureOpenAI_Qdrant_Aspire.verified/aichatweb/aichatweb.Web/aichatweb.Web.csproj).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0004 Update snapshots
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
Updates the "AI Chat Web" project template to use Aspire Azure hosting integrations.
Fixes #6211
Microsoft Reviewers: Open in CodeFlow