Move Microsoft.Extensions.ServiceDiscovery to dotnet/extensions #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…343) * Service Discovery: Allow DNS and DNS SRV to be added independently
* Service Discovery: make host name propagation opt-in * Review feedback
* Last round of triple slash, I believe. * Revert Aspire.sln change * Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs * Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs --------- Co-authored-by: David Fowler <[email protected]>
* Last round of triple slash, I believe. * Revert Aspire.sln change * Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs * Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs --------- Co-authored-by: David Pine <[email protected]>
* Add additional debug logs to Service Discovery * Log message tweak * Use display name instead of GetType().Name for resolver names. Remove nameof
* Add additional debug logs to Service Discovery * Log message tweak * Use display name instead of GetType().Name for resolver names. Remove nameof
* Add package descriptions and icons.
* Add package descriptions and icons. (#701) * Add package descriptions and icons. * Update src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj Co-authored-by: Eric Erhardt <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/Microsoft.Extensions.ServiceDiscovery.Dns.csproj Co-authored-by: Reuben Bond <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj Co-authored-by: Reuben Bond <[email protected]> * Fix package icons. Use base arcade icon for ServiceDiscovery packages. Use the default Aspire icon for Aspire Hosting packages. --------- Co-authored-by: David Fowler <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Reuben Bond <[email protected]>
* Forward port package changes from release branch. * Remove unused dotnet-icon. --------- Co-authored-by: Eric Erhardt <[email protected]>
When PublishTrimmed=true in an app that uses ServiceDiscovery, we get a warning that says: _ILLink : warning IL2105: Microsoft.Extensions.ServiceDiscovery.Abstractions.ServiceEndPointCollection: Type 'ServiceEndPointCollectionDebuggerView' was not found in the caller assembly nor in the base library. Type name strings used for dynamically accessing a type should be assembly qualified._ Fix this warning by using `typeof` instead of `nameof`.
* READMEs for Service Discovery * Update src/Microsoft.Extensions.ServiceDiscovery.Abstractions/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/README.md Co-authored-by: David Pine <[email protected]> --------- Co-authored-by: David Pine <[email protected]>
Merging internal commits from release/8.0-preview1
…view1-to-main [automated] Merge branch 'release/8.0-preview1' => 'main'
…880) * Service Discovery: fix shutdown blocking indefinitely in some cases * Update src/Microsoft.Extensions.ServiceDiscovery/Http/HttpServiceEndPointResolver.cs Co-authored-by: Eric Erhardt <[email protected]> * Review feedback --------- Co-authored-by: Eric Erhardt <[email protected]>
This was referenced Oct 15, 2025
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
24 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I preserved git history using
git filter-repo.Then on top of that history, there is 1 commit for changing the libraries and tests to build cleanly. For now I disable any analyzer warnings that come up. #6871 tracks enabling the analyzers in these libraries in the future.
Contributes to dotnet/aspire#170.
NOTE: This PR shouldn't be "squashed" when merged. Instead it should be a merge commit.
Microsoft Reviewers: Open in CodeFlow