-
Notifications
You must be signed in to change notification settings - Fork 1.9k
macOS x64 CI: fix dependency install and OpenMP runtime copy (use Homebrew libomp, adjust Helix payload) #7510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Commenter does not have sufficient privileges for PR 7510 in repo dotnet/machinelearning |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7510 +/- ##
==========================================
- Coverage 69.01% 69.00% -0.01%
==========================================
Files 1482 1482
Lines 273999 273999
Branches 28258 28258
==========================================
- Hits 189093 189075 -18
- Misses 77520 77536 +16
- Partials 7386 7388 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Commenter does not have sufficient privileges for PR 7510 in repo dotnet/machinelearning |
6c0c6a4
to
47bb847
Compare
e44de68
to
eb0ee80
Compare
…ustom formula path
eb0ee80
to
d282b6a
Compare
I really need these changes, thanks! |
I tried to simplify a bit where x64 and M1 were the same. Let's see if this will also resolve the M1 failure. |
/ba-g Mac-OS unrelated failures |
f0ce5ba
to
1390b39
Compare
PR: macOS x64 CI: fix dependency install and OpenMP runtime copy
Summary
This PR fixes MachineLearning-CI failures on macOS x64 where jobs stop at Install MacOS build dependencies with:
The breakage comes from two areas:
libomp.rb
path that no longer works on hosted macOS images.libomp.dylib
andlibiomp5.dylib
, butlibiomp5.dylib
is not available when installinglibomp
from Homebrew core.Fixes #7509
Changes
build/ci/job-template.yml
brew install …/build/libomp.rb
with standard Homebrew:eng/helix.proj
DYLD_LIBRARY_PATH
so Helix can findlibomp.dylib
./usr/local/opt/libomp/lib/libomp.dylib
into the publish folder.libiomp5.dylib
(not present withlibomp
from Homebrew).@loader_path/libomp.dylib
.Why
libomp
is available via core.Testing
osx.13.amd64.open
queue.libomp.dylib
is present in publish folder.DYLD_LIBRARY_PATH
set correctly.Risk / Impact
Additional Notes
llvm
overlibomp
as the OpenMP provider, happy to adjust.PR Checklist