Verify ICommandElement DependsOn fixes for all implementations #33022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix ICommandElement implementations based on review feedback
Verify ICommandElement DependsOn fixes for all implementations
Dec 5, 2025
Copilot finished work on behalf of
rmarinho
December 5, 2025 16:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Verification that all
ICommandElementimplementations have theDependsOnfix applied in the base branch (#32961).All implementations already fixed:
ButtonElement.cs-DependsOnin static constructorMenuItem.cs-DependsOnin static constructorTextCell.cs-DependsOnin static constructorRefreshView.Mapper.cs-DependsOnin static constructorCheckBox.Mapper.cs-DependsOnin static constructorSearchBar.Mapper.cs-DependsOnin static constructorImageButton- Inherits fromButtonElement.CommandPropertyAll
GetCanExecute()calls correctly pass theCommandPropertyparameter.Issues Fixed
See #32961 for the original fix.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.