Skip to content

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Sep 26, 2025

Description

This PR runs ios_scenarios (build time, startup, and size)measurements for iOS on CoreCLR.

Successful run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2806045&view=results

Depends on dotnet/runtime#120139.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables iOS performance measurements for CoreCLR runtime, extending the existing iOS performance testing infrastructure to support CoreCLR alongside Mono and NativeAOT. It adds configuration for running iOS scenarios (build time, startup, and size measurements) with the CoreCLR runtime.

Key changes:

  • Add CoreCLR runtime type support for iOS scenarios
  • Update build artifact handling for iOS CoreCLR builds
  • Configure pipeline dependencies and artifact downloads for iOS CoreCLR

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/run_performance_job.py Adds iOS CoreCLR runtime type detection and flavor configuration
eng/pipelines/upload-build-artifacts-jobs.yml Configures artifact upload for CoreCLR iOS builds
eng/pipelines/templates/runtime-perf-job.yml Updates job dependencies and artifact downloads to include iOS CoreCLR
eng/pipelines/runtime-ios-scenarios-perf-jobs.yml Adds iOS CoreCLR performance job configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

caaavik-msft
caaavik-msft previously approved these changes Sep 26, 2025
LoopedBard3
LoopedBard3 previously approved these changes Sep 26, 2025
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

LoopedBard3
LoopedBard3 previously approved these changes Sep 29, 2025
@LoopedBard3 LoopedBard3 disabled auto-merge October 3, 2025 16:45
@LoopedBard3 LoopedBard3 merged commit 4dd50d6 into dotnet:main Oct 3, 2025
73 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants