TakeOrSkipWhileQueryOperator: Add lock for _updatesSeen and _currentLowKey comparison #120144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Open
3 tasks
This was referenced Oct 2, 2025
huoyaoyuan
added
area-System.Linq.Parallel
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-linq-parallel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_currentLowKey and _updatesSeen are changed under _operatorState lock, but then they are used without it.
So we can get inconsistent state in comparison (for example: _currentLowKey was already updated but _updatesSeen is not)
Found by Linux Verification Center (linuxtesting.org) with SVACE.