Fix DispatchProxy Generator Issues with AssemblyLoadContexts #120157
+153
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
afifi-ins
force-pushed
the
DispatchProxyGeneraotor
branch
from
f77dbf4 to
eb9aeaf
Compare
jkotas
added
area-System.Reflection
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
Comment on lines
+85
to
+93
| if (s_defaultProxyAssembly == null) | ||
| { | ||
| Interlocked.CompareExchange(ref s_defaultProxyAssembly, new ProxyAssembly(AssemblyLoadContext.Default), null); | ||
| } | ||
|
|
||
| ProxyAssembly proxyAssembly = s_alcProxyAssemblyMap.GetOrAdd(alc, static x => new ProxyAssembly(x)); | ||
| GeneratedTypeInfo proxiedType = proxyAssembly.GetProxyType(baseType, interfaceType, interfaceParameter, proxyParameter); | ||
| return Activator.CreateInstance(proxiedType.GeneratedType, new object[] { proxiedType.MethodInfos })!; | ||
| proxyAssembly = s_defaultProxyAssembly; |
There was a problem hiding this comment.
Is there a benefit to special-case when both ALCs are the default one?
src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.DispatchProxy/tests/DispatchProxyTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Reflection.DispatchProxy/src/System/Reflection/DispatchProxyGenerator.cs
Outdated
Show resolved
Hide resolved
afifi-ins
force-pushed
the
DispatchProxyGeneraotor
branch
from
eb9aeaf to
8423f21
Compare
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two scenarios where DispatchProxy behaves incorrectly when working with multiple AssemblyLoadContexts (ALCs).
Fixes:
Added Unit test to prevent regressions.
Fixes: #109398