[release/10.0] Add proper locking in TranslateSigHelper #120158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
JulieLeeMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
|
/ba-g All failures are known |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120143 to release/10.0
/cc @jkotas @kevingosse
Customer Impact
Missing lock in metadata emitter leads to intermittent crashes when Reflection.Emit is used on multiple threads.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Customer provided test that reproduces the failure reliably
Risk
Low. The same lock is taken on other similar path.