Cleanup PORTABILITY_ASSERTs for finished ports #120183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete PORTABILITY_ASSERT macros and related code that were originally used to mark areas requiring platform-specific implementation. The changes clean up code that is no longer needed now that the relevant platforms (X86, AMD64, ARM, ARM64) have been fully ported.
Key changes:
- Removed PORTABILITY_ASSERT statements for completed platform ports
- Updated PORTABILITY macros to include all finished ports (X86, AMD64, ARM, ARM64)
- Simplified platform-specific code by removing unnecessary conditional compilation blocks
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/threadsuspend.cpp | Refactored ExecutionState struct and removed X86-specific PORTABILITY_ASSERT |
| src/coreclr/vm/threads.cpp | Removed PORTABILITY_ASSERT and unnecessary platform-specific comments |
| src/coreclr/utilcode/dacutil.cpp | Replaced platform-specific machine type logic with IMAGE_FILE_MACHINE_NATIVE |
| src/coreclr/inc/palclr.h | Extended PORTABILITY macro conditions to include all finished ports |
| src/coreclr/debug/di/valuehome.cpp | Removed PORTABILITY_ASSERT and outdated platform comments |
jkotas
commented
Sep 29, 2025
AaronRobinsonMSFT
approved these changes
Sep 29, 2025
jkotas
commented
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44132