Split 'dotnet test' classes in two directories (VSTest/MTP) #50639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Sep 4, 2025
| @@ -10,21 +10,18 @@ | |||
|
|
|||
| namespace Microsoft.DotNet.Cli.Commands.Test; | |||
|
|
|||
| internal partial class TestingPlatformCommand : Command, ICustomHelp | |||
| internal partial class MicrosoftTestingPlatformTestCommand : Command, ICustomHelp, ICommandDocument | |||
There was a problem hiding this comment.
The additional interface is for #50638
drognanar
reviewed
Sep 5, 2025
| PrepareEnvironment(parseResult, out TestOptions testOptions, out int degreeOfParallelism); | ||
| int degreeOfParallelism = GetDegreeOfParallelism(parseResult); | ||
| bool filterModeEnabled = parseResult.HasOption(MicrosoftTestingPlatformOptions.TestModulesFilterOption); | ||
| var testOptions = new TestOptions(filterModeEnabled, IsHelp: isHelp); |
There was a problem hiding this comment.
is the isHelp passed to the child processes?
There was a problem hiding this comment.
Yes, in TestApplication class where we start the child process, we check for IsHelp and pass ---help to test app. The only potential broken scenario today is when you try to bypass CLI knowledge of --help and end up passing it to the test app. For example, dotnet test -p:TestingPlatformCommandLineArguments=--help. In this case, CLI doesn't know that we are in help mode.
drognanar
approved these changes
Sep 5, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier when working with test command to understand which classes are specific to VSTest, and which are specific to Microsoft.Testing.Platform.
Classes outside of these two directories are used by both. This can be refactored further as some of these "common" classes have parts that are VSTest and parts that are MTP, and can be split to more classes for clarity. But that's a separate refactor.
Also cleans up a bit of logic so that it's easier to follow.