Add tests for solution filter with shared projects and platform configuration support #51526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test for solution filter with shared projects (.shproj) being properly skipped - Test for Platform configuration being respected in solution builds - Both test assets include proper global.json to enable MTP mode Co-authored-by: Youssef1313 <[email protected]>
Copilot
AI
changed the title
[WIP] Make requested changes to #51411
Add tests for solution filter with shared projects and platform configuration support
Nov 3, 2025
Copilot finished work on behalf of
Youssef1313
November 3, 2025 13:49
Youssef1313
reviewed
Nov 4, 2025
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> |
Youssef1313
reviewed
Nov 4, 2025
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <IsTestingPlatformApplication>true</IsTestingPlatformApplication> |
Member
There was a problem hiding this comment.
@copilot Remove IsTestingPlatformApplication from this project as well as other csproj files added in this PR.
Contributor
Author
There was a problem hiding this comment.
Removed IsTestingPlatformApplication property from all four csproj files in commit 201ea92.
The property is not needed and was removed from all four csproj files in the test assets. Co-authored-by: Youssef1313 <[email protected]>
The property is not needed and was removed from all four csproj files in the test assets. Co-authored-by: Youssef1313 <[email protected]>
Copilot finished work on behalf of
Youssef1313
November 4, 2025 11:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet testshould respect platform #51481 (solution with platform configurations)dotnet testshould respect platform #51481💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.