-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update InputLanguage.cs #13925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update InputLanguage.cs #13925
Conversation
Streamline `InputLanguage.LayoutId` logic for clarity and maintainability, preserving existing behavior.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13925 +/- ##
====================================================
- Coverage 77.15465% 52.01209% -25.14257%
====================================================
Files 3276 2064 -1212
Lines 645116 287885 -357231
Branches 47705 42112 -5593
====================================================
- Hits 497737 149735 -348002
+ Misses 143692 135258 -8434
+ Partials 3687 2892 -795
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@JeremyKuhne can you please take a look? |
|
@DJm00n Thanks! Note that I'm no longer on the WinForms team. You can still feel free to ping me if there is something that I might have knowledge on. In this particular case I don't think this change is a good idea:
Outside of this case, we should be ensuring that any changes are well covered in unit tests that come in as a separate PR to ensure that we're not breaking behavior. That said, this is in @merriemcgaw, @Shyam-Gupta, and @KlausLoeffelmann hands now, I'll let them give their take. :) |
Streamline
InputLanguage.LayoutIdlogic for clarity and maintainability, preserving existing behavior.Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow