Skip to content

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Oct 30, 2025

Backport #10243 to release/8.0

Fixes #13994

Proposed changes

  • Creates a new switch that allows developers to configure their application to make the starting index of rows/cells in DataGridView to be read by Narrator from 1, instead of 0;
  • Adds checks on rows and cells of DataGridView to see if the switch is true. If true, starting index of rows/cells will be 1, instead of 0.

Customer Impact

  • Developers will be able to configure their WinForms DataGridView rows/cells to be read by Narrator from index 1, instead of 0.

Regression?

  • No

Risk

  • Low

Test methodology

  • Manual testing
  • Unit tests
Microsoft Reviewers: Open in CodeFlow

…chCountDataGridRowColumnAt1

Adjusts DataGridView UIA to count rows at index 1 by default, and creates a switch to enable user to set the count to start at 0
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@merriemcgaw merriemcgaw added the servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label Nov 19, 2025
@LeafShi1 LeafShi1 added this to the 8.0.23 milestone Nov 19, 2025
@merriemcgaw merriemcgaw removed the servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label Nov 21, 2025
@merriemcgaw
Copy link
Member

@KlausLoeffelmann @Shyam-Gupta I'd like you two to weigh in before we take this. It was approved by Tactics, but I realized that this adds the switch which enables the starting count at 1 rather than 0. That's a behavior change, but @LeafShi1 can tell us whether this new behavior is enabled by default or not. The SSMA team would still have to update their app to turn on the feature if I'm not mistaken. We could never turn this on by default, and if they can't enable this, then maybe we don't need it in servicing and they can just take it when they get to migrate from 8->10.

@LeafShi1
Copy link
Member Author

LeafShi1 commented Nov 24, 2025

@LeafShi1 can tell us whether this new behavior is enabled by default or not.

it's enabled by default

private static int RowStartIndex => AppContextSwitches.DataGridViewUIAStartRowCountAtZero ? 0 : 1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants