Make plugin work in the latest nigthly version of NINA #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing method 2. Somehow Sony A6600 doesn't provide list of ISOs, so plugin can't initialize. Make it safer
…ld be used Limit irrelevant iso values like Multi Frame NR High ISO which are not used in NINA
dougforpres
reviewed
Nov 15, 2025
|
|
||
| return (int)gainInfo.Options().Last().Value; | ||
| return (int)gainInfo.Options().Where(o => o.Value <= 0x00FFFFFF).Last().Value; | ||
| } catch (Exception ex) { |
Owner
There was a problem hiding this comment.
Function is getGainMax, shouldn't the error reflect the name?
Same goes for the getGainMin where the error states it was a problem getting max
|
I cannot see the new release available in nina. Has it been pushed? |
Contributor
|
@totoantibes It hasn't been updated in the NINA Plugin yet. but it shouldn't be long @dougforpres is already on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6 #2 (haha, by me)