This repository was archived by the owner on Feb 23, 2020. It is now read-only.
add waitlist features #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll want to keep |
|
To determine when to start adding registrations to the waitlist, it appears that the "Maximum registrants" setting value is what is being checked. However, in the description for the field it specifies that this value is intended to be "maximum registrants per registration" and NOT the total maximum. There is currently no value for maximum number of attendees (registrants); see #171. |
|
Merged into freelock/rng, along with #171 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95 and fixes #77.
I added a bunch of events so I can easily override and tweak how the default implementation works. For example, maybe I want to have a waiting list, but only allow at most 5 or 10 people on that waiting list. Then revert to a max cap again. By using events and
stopPropogation, this is pretty easy to do. Same with the wording of the waitlist message. I need to be able to override that default wording and I can easily do that by adding my own event subscriber, setting a message and stopPropogation will disable the default from this module.