Skip to content

[WIP] feat: Add cache encryption implementation for Storage #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] feat: Add cache encryption implementation for Storage #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273d418
feat: add encryption key api
ChoHee15 Aug 9, 2025
5cac506
feat: manager decide whether to enable encryption
ChoHee15 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
460 changes: 349 additions & 111 deletions pkg/apis/manager/v2/manager.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

296 changes: 296 additions & 0 deletions pkg/apis/manager/v2/manager.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 29 additions & 0 deletions pkg/apis/manager/v2/manager.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,32 @@ message KeepAliveRequest {
string ip = 4 [(validate.rules).string = {ip: true, ignore_empty: true}];
}

// RequestEncryptionKeyRequest represents request of RequestEncryptionKey.
message RequestEncryptionKeyRequest {
// Request source type.
SourceType source_type = 1 [(validate.rules).enum.defined_only = true];
// Source service hostname.
string hostname = 2 [(validate.rules).string.hostname = true];
// Source service ip.
string ip = 3 [(validate.rules).string.ip = true];
}

// Encryption status enumeration.
enum EncryptionStatus {
// Encryption is not enabled.
ENCRYPTION_DISABLED = 0;
// Encryption is enabled and key is provided.
ENCRYPTION_ENABLED = 1;
}

// RequestEncryptionKeyResponse represents response of RequestEncryptionKey.
message RequestEncryptionKeyResponse {
// Encryption status.
EncryptionStatus status = 1 [(validate.rules).enum.defined_only = true];
// Encryption key provided by manager (only present when status is ENCRYPTION_ENABLED).
optional bytes encryption_key = 2 [(validate.rules).bytes = {min_len: 32, max_len: 1024}];
}

// Manager RPC Service.
service Manager {
// Get SeedPeer and SeedPeer cluster configuration.
Expand Down Expand Up @@ -330,4 +356,7 @@ service Manager {

// KeepAlive with manager.
rpc KeepAlive(stream KeepAliveRequest)returns(google.protobuf.Empty);

// Request encryption key from manager.
rpc RequestEncryptionKey(RequestEncryptionKeyRequest) returns(RequestEncryptionKeyResponse);
}
Loading