Skip to content

Conversation

@MSadeghzadehG
Copy link

@MSadeghzadehG MSadeghzadehG commented Apr 17, 2020

I didn't see any other parts that need to change. if there is, please mention.

@MSadeghzadehG
Copy link
Author

PTAL @john-bodley @mistercrunch

@JustFeng
Copy link

thx

@john-bodley
Copy link
Contributor

@MSadeghzadehG should the list contain all the scan-query properties?

@MSadeghzadehG
Copy link
Author

MSadeghzadehG commented Apr 21, 2020

@john-bodley the resultFormat, batch_size, and legacy are missing. and I didn't see metrics property in scan query parameters.
and I think the batch_size should add to the list. what's your opinion?

@MSadeghzadehG
Copy link
Author

@JustFeng you're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants