Support yarn-path config option in yarnrc #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NMinhNguyen
reviewed
Nov 18, 2021
| const yarnrc = parse(readFileSync(yarnrcPath).toString("UTF8")) | ||
| .object as any | ||
| if (yarnrc["yarn-path"]) { | ||
| yarnrc["yarn-path"] = join(appPath, yarnrc["yarn-path"]) |
There was a problem hiding this comment.
I wonder if path.resolve would be better than path.join in case the path has something like ../
lencioni
approved these changes
Jul 6, 2022
|
I merged some upstream changes related to the yarnk lockfile which caused some conflicts, and the changes aren't quite simple enough that I'd feel comfortable using the web editor for the conflicts. I think this is something we should get merged, so if you'd like to rebase, I'm happy to get it in. I think I also agree with @NMinhNguyen on using resolve too (but I'm not 100%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347