Skip to content

Support static member functions & c++ constructor of shared type #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support static member functions & c++ constructor of shared type #1430

wants to merge 2 commits into from

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Jan 31, 2025 •
edited
Loading

Implement #447 (comment)

  • cxx side static member functions
  • export as static member functions in rust side as well
  • rust side static member functions
  • when returns Self with #[Self = ], it defined as constructor in c++

Close #1419, fix #464

@yujincheng08 yujincheng08 force-pushed the static branch 3 times, most recently from 7127d9d to 7485943 Compare January 31, 2025 17:15
@yujincheng08 yujincheng08 marked this pull request as ready for review January 31, 2025 17:15
@yujincheng08 yujincheng08 force-pushed the static branch 2 times, most recently from 7150b2e to fc2504a Compare January 31, 2025 17:34
@yujincheng08 yujincheng08 changed the title Support static member functions Support static member functions & constructor of shared type Feb 1, 2025
@yujincheng08 yujincheng08 changed the title Support static member functions & constructor of shared type Support static member functions & c++ constructor of shared type Feb 1, 2025
@yujincheng08 yujincheng08 changed the title Support static member functions & c++ constructor of shared type Support static member functions Feb 1, 2025
@yujincheng08 yujincheng08 force-pushed the static branch 4 times, most recently from fd46613 to 094a7be Compare February 2, 2025 09:13
@yujincheng08 yujincheng08 changed the title Support static member functions Support static member functions & c++ constructor of shared type Feb 2, 2025
@yujincheng08 yujincheng08 force-pushed the static branch 2 times, most recently from 0e8a115 to e270c9c Compare February 2, 2025 10:29
@yujincheng08
Copy link
Contributor Author

@dtolnay any chance this PR gets review?

@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

1 similar comment
@yujincheng08
Copy link
Contributor Author

@dtolnay gental ping

@dtolnay dtolnay mentioned this pull request Aug 7, 2025
Merged
dtolnay
dtolnay reviewed Aug 7, 2025
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I moved one of the commits from this PR to #1546 for review. Please open a separate PR for the constructor feature.

@dtolnay dtolnay closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static member functions Specify name of class that static method is defined on
2 participants
@yujincheng08 @dtolnay