Make .start() and .end() work on Rust 1.88. #508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorArcium
added a commit
to arcium-hq/proc-macro2
that referenced
this pull request
Aug 14, 2025
|
Hi @dtolnay, I wanna use this too, so would be awesome to get this merged! Do you have an ETA on when/if this will land? |
dtolnay
reviewed
Aug 16, 2025
| println!("cargo:rustc-cfg=proc_macro_span"); | ||
| } | ||
|
|
||
| if proc_macro_span_location { |
There was a problem hiding this comment.
Suggested change
| if proc_macro_span_location { | |
| if proc_macro_span || rustc >= 88 { |
dtolnay
requested changes
Aug 16, 2025
There was a problem hiding this comment.
This implementation is going to cause build failures for projects that use allow-features=.
$ RUSTFLAGS=-Zallow-features= cargo +nightly-2025-04-26 check --features=span-locations
error[E0658]: use of unstable library feature `proc_macro_span`
--> src/wrapper.rs:436:25
|
436 | line: s.line(),
| ^^^^
|
= note: see issue #54725 <https://github.com/rust-lang/rust/issues/54725> for more information
= help: add `#![feature(proc_macro_span)]` to the crate attributes to enable
= note: this compiler was built on 2025-04-25; consider upgrading it if it is out of dateI put up a safer alternative in #517. Thanks anyway for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of
proc_macro2::Spanmethods have been stabilized in Rust 1.88: https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.line.This PR makes
.start()and.end()work using these new methods.