Refactor S3 Multi part upload to separate class #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the S3 multi part upload code into a separate class from the S3FileHandle. It is kept alive separately and performs the Put/Post requests separately from the S3FileHandle. This greatly simplifies reasoning about lifetimes as we are no longer launching background threads that are dependent on external state (the file handle) being kept alive. This likely fixes some edge case issues around writes in particular when dealing with exceptions.
This shouldn't change behavior - but given this is a relatively sizeable refactor I would not include this for the v1.3.2 release.