Skip to content

cache the result of isAppleSilicon() #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

cache the result of isAppleSilicon() #1828

merged 3 commits into from
Jul 21, 2025

Conversation

muodov
Copy link
Member

@muodov muodov commented Jul 17, 2025

Asana Task/Github Issue:

Description

noticed this when working on https://app.asana.com/1/137249556945/project/1206777341262243/task/1210285801262935?focus=true. It causes "too many gl contexts" errors in Outlook

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@muodov muodov requested a review from a team as a code owner July 17, 2025 13:07
Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 258c956
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6878fc8379a7300008974956
😎 Deploy Preview https://deploy-preview-1828--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jul 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 17, 2025

[Beta] Generated file diff

Time updated: Thu, 17 Jul 2025 13:38:49 GMT

Android
    - android/autofillPasswordImport.js
  • android/brokerProtection.js
  • android/contentScope.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

cursor[bot]

This comment was marked as outdated.

@muodov muodov requested a review from jonathanKingston July 17, 2025 13:11
cursor[bot]

This comment was marked as outdated.

@jonathanKingston
Copy link
Contributor

Nice, yeah. I've been meaning to cache the entire computation of settings and patches (and stale it if any condition changes). But yeah this is a nice pragmatic bump, :)

@muodov muodov force-pushed the cache-is-applesilicon branch from b30042a to 258c956 Compare July 17, 2025 13:37
@muodov muodov added the patch Increment the patch version when merged label Jul 21, 2025
@muodov muodov merged commit 0249d4e into main Jul 21, 2025
16 checks passed
@muodov muodov deleted the cache-is-applesilicon branch July 21, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants