Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
2bdae75
Initial setup, adjust styles and prep for new data
jsoningram Oct 24, 2025
8ebfc34
WIP on activity details
jsoningram Oct 24, 2025
ab71dc2
Add cookiePopUpBlocked to TrackingStatus
jsoningram Oct 24, 2025
548e837
Implement tooltip
jsoningram Oct 24, 2025
aa940eb
Update types
jsoningram Oct 27, 2025
d71a04b
Wire up mock data and provide fallback for platforms not ready for up…
jsoningram Oct 27, 2025
e7150b2
Fix errors from lint-fix
jsoningram Oct 28, 2025
29833f9
Add @todos
jsoningram Oct 28, 2025
8be8fa0
Add testing states
jsoningram Oct 28, 2025
4b45cc9
Update test cases
jsoningram Oct 29, 2025
6959252
Update fire icon in Activity details and animation on info icon hover
jsoningram Oct 30, 2025
3d9f932
Ensure cookie pill is visible on details even if no trackers are found
jsoningram Oct 30, 2025
8f2e728
Fix for duplicate protections_onDataUpdate
jsoningram Nov 17, 2025
ebdcdb7
Address PR comments
jsoningram Nov 17, 2025
2538591
Update test cases
jsoningram Nov 17, 2025
2bbf53f
Fix no message for zero trackers
jsoningram Nov 18, 2025
d11fbd0
Make tooltip accessible and adjust tests
jsoningram Nov 18, 2025
b192579
Update test cases
jsoningram Nov 19, 2025
632d102
Fix linter issues
jsoningram Nov 19, 2025
93220b2
Set totalCookiePopUpsBlocked to undefined by default to mimic current…
jsoningram Nov 20, 2025
7a5467e
Address Cursor bot concern: Bug: Checkmark icon shown for zero-tracke…
jsoningram Nov 20, 2025
920e9b4
Update fire icon to resolve failing snapshots
jsoningram Nov 20, 2025
a686401
Fix linter issues
jsoningram Nov 20, 2025
0b4323f
Update UI state for snapshots
jsoningram Nov 20, 2025
95d641d
Adjust isCpmEnabled logic
jsoningram Nov 21, 2025
c9fa173
Fix failing test
jsoningram Nov 21, 2025
9791ad7
Fix failing tests
jsoningram Nov 21, 2025
bb1f67a
Fix failing tests
jsoningram Nov 21, 2025
f456be4
Update strings to clarify intent for the translators
jsoningram Nov 21, 2025
14112da
Address screenshot issues
jsoningram Nov 21, 2025
7b4a5ae
Add translations
jsoningram Nov 21, 2025
be4267b
Address remaining screenshot issues
jsoningram Nov 21, 2025
582008c
Adjust Activity examples to accept legacy UI prop
jsoningram Nov 21, 2025
a73ea6a
Adjust ProtectionsHeading examples to accept legacy UI prop
jsoningram Nov 21, 2025
00b25ba
Fix integration test
jsoningram Nov 21, 2025
ff9568f
Fix integration test
jsoningram Nov 21, 2025
7bd10fc
Fix shift of Protections Report content when switching to Details view
jsoningram Nov 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import { ACTION_BURN } from '../burning/BurnProvider.js';
* @property {Record<string, boolean>} favorites
* @property {string[]} urls
* @property {number} totalTrackers
* @property {Record<string, boolean|null|undefined>} cookiePopUpBlocked
*/

/**
Expand All @@ -52,6 +53,7 @@ export function normalizeData(prev, incoming) {
trackingStatus: {},
urls: [],
totalTrackers: incoming.totalTrackers,
cookiePopUpBlocked: {},
};

if (shallowDiffers(prev.urls, incoming.urls)) {
Expand All @@ -64,6 +66,7 @@ export function normalizeData(prev, incoming) {
const id = item.url;

output.favorites[id] = item.favorite;
output.cookiePopUpBlocked[id] = item.cookiePopUpBlocked;

/** @type {Item} */
const next = {
Expand Down Expand Up @@ -187,6 +190,7 @@ export function SignalStateProvider({ children }) {
favorites: {},
urls: [],
totalTrackers: 0,
cookiePopUpBlocked: {},
},
{ activity: state.data.activity, urls: state.data.urls, totalTrackers: state.data.totalTrackers },
),
Expand Down
5 changes: 3 additions & 2 deletions special-pages/pages/new-tab/app/activity/activity.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ title: Activity
"url": "https://youtube.com/watch?v=abc",
"relativeTime": "Just now"
}
]
],
"cookiePopUpBlocked": true,
}
]
}
Expand Down Expand Up @@ -178,4 +179,4 @@ example payload without id (for example, on history items)
```

### `activity_burnAnimationComplete`
- Sent when the burn animation completes
- Sent when the burn animation completes
Original file line number Diff line number Diff line change
Expand Up @@ -9,32 +9,32 @@ import { normalizeData, NormalizedDataContext } from '../NormalizeDataProvider.j
export const activityExamples = {
'activity.empty': {
factory: () => {
return <Activity itemCount={0} batched={false} />;
return <Activity itemCount={0} batched={false} shouldDisplayLegacyActivity={true} />;
},
},
'activity.few': {
factory: () => (
<Activity itemCount={10} batched={false}>
<Activity itemCount={10} batched={false} shouldDisplayLegacyActivity={true}>
<Mock size={3}>
<ActivityBody canBurn={false} visibility={'visible'} />
<ActivityBody canBurn={false} visibility={'visible'} shouldDisplayLegacyActivity={true} />
</Mock>
</Activity>
),
},
'activity.noTrackers': {
factory: () => (
<Activity itemCount={20} batched={false}>
<Activity itemCount={20} batched={false} shouldDisplayLegacyActivity={true}>
<Mock size={1}>
<ActivityBody canBurn={false} visibility={'visible'} />
<ActivityBody canBurn={false} visibility={'visible'} shouldDisplayLegacyActivity={true} />
</Mock>
</Activity>
),
},
'activity.noActivity.someTrackers': {
factory: () => (
<Activity itemCount={0} batched={false}>
<Activity itemCount={0} batched={false} shouldDisplayLegacyActivity={true}>
<Mock size={0}>
<ActivityBody canBurn={false} visibility={'visible'} />
<ActivityBody canBurn={false} visibility={'visible'} shouldDisplayLegacyActivity={true} />
</Mock>
</Activity>
),
Expand All @@ -58,6 +58,7 @@ function Mock({ children, size }) {
favorites: {},
urls: [],
totalTrackers: 0,
cookiePopUpBlocked: {},
},
{ activity: mocks, urls: mocks.map((x) => x.url), totalTrackers: 0 },
);
Expand Down
Loading