Add js user agent client hints brand header-matching feature #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated file outputs:Time updated: Thu, 11 Dec 2025 15:12:24 GMT legacytrackers-unprotected-temporary.txt3 files changed
--- v3/macos-config.json (and 2 other files)
+++ v3/macos-config.json
@@ -101981,8 +101981,21 @@
},
"state": "enabled",
"minSupportedVersion": "0.22.3"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
+ },
+ {
+ "domain": "noaprints.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2143"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
10 files changed
--- v3/extension-safarimv3-config.json (and 9 other files)
+++ v3/extension-safarimv3-config.json
@@ -13493,8 +13493,41 @@
},
"state": "enabled",
"minSupportedVersion": "2023.5.23"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
+ },
+ {
+ "domain": "noaprints.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2143"
+ },
+ {
+ "domain": "localhost",
+ "reason": "Protections are disabled on localhost pages"
+ },
+ {
+ "domain": "127.0.0.1",
+ "reason": "Protections are disabled on localhost pages"
+ },
+ {
+ "domain": "::1",
+ "reason": "Protections are disabled on localhost pages"
+ },
+ {
+ "domain": "livenation.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1053"
+ },
+ {
+ "domain": "ticketmaster.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/issues/794"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
v3/windows-config.json--- v3/windows-config.json
+++ v3/windows-config.json
@@ -104306,8 +104306,43 @@
]
},
"state": "disabled"
},
+ "uaChBrands": {
+ "state": "enabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
+ },
+ {
+ "domain": "noaprints.com",
+ "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2143"
+ }
+ ],
+ "settings": {
+ "additionalCheck": "disabled",
+ "conditionalChanges": [
+ {
+ "condition": [
+ {
+ "internal": true
+ },
+ {
+ "preview": true
+ }
+ ],
+ "patchSettings": [
+ {
+ "op": "replace",
+ "path": "/additionalCheck",
+ "value": "enabled"
+ }
+ ]
+ }
+ ]
+ }
+ },
"urlPredictor": {
"exceptions": [],
"state": "disabled",
"settings": {
3 files changed
--- v4/macos-config.json (and 2 other files)
+++ v4/macos-config.json
@@ -100921,8 +100921,19 @@
},
"state": "enabled",
"minSupportedVersion": "0.22.3"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
10 files changed
--- v4/extension-safarimv3-config.json (and 9 other files)
+++ v4/extension-safarimv3-config.json
@@ -12306,8 +12306,34 @@
},
"state": "enabled",
"minSupportedVersion": "2023.5.23"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ },
+ {
+ "domain": "localhost"
+ },
+ {
+ "domain": "127.0.0.1"
+ },
+ {
+ "domain": "::1"
+ },
+ {
+ "domain": "livenation.com"
+ },
+ {
+ "domain": "ticketmaster.com"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
v4/windows-config.json--- v4/windows-config.json
+++ v4/windows-config.json
@@ -103270,8 +103270,41 @@
]
},
"state": "disabled"
},
+ "uaChBrands": {
+ "state": "enabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ }
+ ],
+ "settings": {
+ "additionalCheck": "disabled",
+ "conditionalChanges": [
+ {
+ "condition": [
+ {
+ "internal": true
+ },
+ {
+ "preview": true
+ }
+ ],
+ "patchSettings": [
+ {
+ "op": "replace",
+ "path": "/additionalCheck",
+ "value": "enabled"
+ }
+ ]
+ }
+ ]
+ }
+ },
"urlPredictor": {
"exceptions": [],
"state": "internal",
"settings": {
latest3 files changed
--- v5/macos-config.json (and 2 other files)
+++ v5/macos-config.json
@@ -100921,8 +100921,19 @@
},
"state": "enabled",
"minSupportedVersion": "0.22.3"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
10 files changed
--- v5/extension-safarimv3-config.json (and 9 other files)
+++ v5/extension-safarimv3-config.json
@@ -12306,8 +12306,34 @@
},
"state": "enabled",
"minSupportedVersion": "2023.5.23"
},
+ "uaChBrands": {
+ "state": "disabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ },
+ {
+ "domain": "localhost"
+ },
+ {
+ "domain": "127.0.0.1"
+ },
+ {
+ "domain": "::1"
+ },
+ {
+ "domain": "livenation.com"
+ },
+ {
+ "domain": "ticketmaster.com"
+ }
+ ]
+ },
"voiceSearch": {
"exceptions": [],
"state": "disabled"
},
v5/windows-config.json--- v5/windows-config.json
+++ v5/windows-config.json
@@ -103270,8 +103270,41 @@
]
},
"state": "disabled"
},
+ "uaChBrands": {
+ "state": "enabled",
+ "exceptions": [
+ {
+ "domain": "marvel.com"
+ },
+ {
+ "domain": "noaprints.com"
+ }
+ ],
+ "settings": {
+ "additionalCheck": "disabled",
+ "conditionalChanges": [
+ {
+ "condition": [
+ {
+ "internal": true
+ },
+ {
+ "preview": true
+ }
+ ],
+ "patchSettings": [
+ {
+ "op": "replace",
+ "path": "/additionalCheck",
+ "value": "enabled"
+ }
+ ]
+ }
+ ]
+ }
+ },
"urlPredictor": {
"exceptions": [],
"state": "internal",
"settings": {
|
JSON approval analysis:Time updated: Thu, 11 Dec 2025 15:12:28 GMT legacy❌ Manual Review Required
latest❌ Manual Review Required
🎯 OVERALL APPROVAL STATUS❌ MANUAL REVIEW REQUIRED |
jonathanKingston
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/45878998844068/task/1212017506660685?focus=true
Not sure if we want to flip to
enabledimmediately or do that separately? Wdyt, @jonathanKingston ? (looks like we got the native bump to C-S-S 12.2.0 into preview v.0.141.5 🎉 )Feature change process:
Note
Introduces the
uaChBrandsfeature (schema, base config, build integration) and enables it on Windows with a conditionaladditionalCheck; also addspreviewto condition blocks.uaChBrands:schema/features/ua-ch-brands.ts) and base config (features/ua-ch-brands.json).schema/config.ts).index.js).additionalCheckand conditional patch wheninternalandpreview(overrides/windows-override.json).previewcondition support toConditionBlock(schema/feature.ts).Written by Cursor Bugbot for commit 3aa170b. This will update automatically on new commits. Configure here.