Skip to content

Conversation

@RendijsSmukulis
Copy link
Contributor

@RendijsSmukulis RendijsSmukulis commented Dec 9, 2025

Description

Kill service_worker watchdog to validate if its causing webview2 stability issues


Note

Disables serviceWorkerWatchdog and serviceWorkerWatchdogUnregister in overrides/windows-override.json under features.webview.

  • Windows config (overrides/windows-override.json):
    • Webview features:
      • Set features.webview.serviceWorkerWatchdog to disabled (was enabled).
      • Set features.webview.serviceWorkerWatchdogUnregister to disabled (was preview).

Written by Cursor Bugbot for commit b8075be. This will update automatically on new commits. Configure here.

@RendijsSmukulis RendijsSmukulis requested review from a team and daxtheduck as code owners December 9, 2025 15:48
github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Generated file outputs:

Time updated: Tue, 09 Dec 2025 15:51:23 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

2 files changed
  • v3/windows-config.json
  • v4/windows-config.json
--- v4/windows-config.json (and 1 other files)
+++ v4/windows-config.json
@@ -103539,9 +103539,9 @@
                         ]
                     }
                 },
                 "serviceWorkerWatchdog": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "serviceWorkerWatchdogUnregister": {
                     "state": "disabled"
                 }
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/ios-config.json
  • v5/macos-config.json

⚠️ File is identical

v5/windows-config.json
--- v5/windows-config.json
+++ v5/windows-config.json
@@ -103539,12 +103539,12 @@
                         ]
                     }
                 },
                 "serviceWorkerWatchdog": {
-                    "state": "enabled"
+                    "state": "disabled"
                 },
                 "serviceWorkerWatchdogUnregister": {
-                    "state": "preview"
+                    "state": "disabled"
                 }
             },
             "exceptions": []
         },

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

JSON approval analysis:

Time updated: Tue, 09 Dec 2025 15:51:27 GMT

legacy

❌ Manual Review Required

  • v3/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/webview/features/serviceWorkerWatchdog/state (replace)
  • v4/windows-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/webview/features/serviceWorkerWatchdog/state (replace)
latest

❌ Manual Review Required

  • v5/windows-config.json (2 total changes)
    Disallowed paths that require review:
    • /features/webview/features/serviceWorkerWatchdogUnregister/state (replace)
    • /features/webview/features/serviceWorkerWatchdog/state (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

@RendijsSmukulis RendijsSmukulis added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit 215c27d Dec 10, 2025
15 of 23 checks passed
@RendijsSmukulis RendijsSmukulis deleted the randy/disable_serviceWorkerWatchdog branch December 10, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants