Fix: Add IP validation in MachineRegistryController for security #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proper IP address validation in the MachineRegistryController to prevent potential security issues related to malformed IP inputs.
The fix was implemented in the original Alibaba Sentinel repository in commit d4ea89e.
Changes:
Added validation to ensure IP inputs are valid IPv4 or IPv6 addresses
Uses IPAddressUtil to perform proper format validation
Rejects any malformed IP addresses before they can be processed
Without this validation, the application accepts any string as an IP address, which could lead to unexpected behavior or security vulnerabilities downstream.