Skip to content

Fix Next nav button doesnt work on last slide #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Next nav button doesnt work on last slide #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/swiffy-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
const swiffyslider = function() {
const swiffyslider = function () {
return {
version: "1.6.0",
init(rootElement = document.body) {
rootElement.querySelectorAll(".swiffy-slider").forEach(sliderElement => this.initSlider(sliderElement));
},

initSlider(sliderElement) {
this.adjustForParentPadding(sliderElement); // Adjust for parent padding dynamically

sliderElement.querySelectorAll(".slider-nav").forEach(navElement =>
navElement.addEventListener("click", () => this.slide(sliderElement, navElement.classList.contains("slider-nav-next")), { passive: true })
);
Expand All @@ -23,6 +25,23 @@ const swiffyslider = function() {
}
},

adjustForParentPadding(sliderElement) {
const sliderContainer = sliderElement.querySelector(".slider-container");
if (!sliderContainer) {
return;
}
let totalPadding = 0;
let currentElement = sliderContainer.parentElement;
while (currentElement) {
const styles = getComputedStyle(currentElement);
const paddingLeft = parseFloat(styles.paddingLeft) || 0;
const paddingRight = parseFloat(styles.paddingRight) || 0;
totalPadding += paddingLeft + paddingRight;
currentElement = currentElement.parentElement;
}
sliderContainer.style.setProperty("--swiffy-slider-item-reveal", `${totalPadding}px`);
},

setVisibleSlides(sliderElement, threshold = 0.3) {
let observer = new IntersectionObserver(slides => {
slides.forEach(slide => {
Expand Down Expand Up @@ -142,4 +161,4 @@ if (!document.currentScript.hasAttribute("data-noinit")) {
}
}
}
}
}