Add support for two-factor HW passkey (FIDO2) #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a password, a fido2/ctap2 hardware passkey can be used to lock/unlock tombs. When using `--fido2` option, keys are forged as usual, but they prompt automatically detected fido2 hardware keys when a password should be supplied. The .key file with metadata does not contain any secrets. The option is also used for lock/open operations. Password interactions are replaced with FIDO2 passkey interaction (requiring a pin to unlock the token).
jaromil
reviewed
Dec 15, 2025
tomb
Outdated
| return 0 } | ||
|
|
||
| if option_is_set --fido2 && [[ $TOMB_FIDO2 == 0 ]]; then | ||
| _failure "This key is missing FIDO2 metadata. Re-forge the key with --fido2 or use a non-FIDO2 workflow." |
Member
There was a problem hiding this comment.
best written "This key was not forged using --fido2"
to suggest reforging a key may confuse neofites trying it out and then deleting and redoing keys...
Member
|
Many thanks for this amazing feature! long due... |
Member
|
There is a regression in the way key headers are parsed in case of KDF https://github.com/dyne/tomb/actions/runs/20250237728/job/58140360492#step:9:1739 |
Collaborator
|
Minor remark that there are now two translateable strings where the variable is directly in the string: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a password, a fido2/ctap2 hardware passkey can be used to lock/unlock tombs.
When using
--fido2option, keys are forged as usual, but they prompt automatically detected fido2 hardware keys when a password should be supplied. The .key file with metadata does not contain any secrets.The option is also used for lock/open operations. Password interactions are replaced with FIDO2 passkey interaction (requiring a pin to unlock the token).