Skip to content

Pass debug explicitly to Sandbox in tests #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Pass debug explicitly to Sandbox in tests #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/js-sdk/tests/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const sandboxTest = base.extend<SandboxFixture>({
sandbox: [
// eslint-disable-next-line no-empty-pattern
async ({}, use) => {
const sandbox = await Sandbox.create(template)
const sandbox = await Sandbox.create(template, { debug: isDebug })
try {
await use(sandbox)
} finally {
Expand Down
4 changes: 2 additions & 2 deletions packages/python-sdk/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def template():

@pytest.fixture()
def sandbox(template, debug):
sandbox = Sandbox(template)
sandbox = Sandbox(template, debug=debug)

try:
yield sandbox
Expand All @@ -38,7 +38,7 @@ def sandbox(template, debug):

@pytest_asyncio.fixture
async def async_sandbox(template, debug):
sandbox = await AsyncSandbox.create(template)
sandbox = await AsyncSandbox.create(template, debug=debug)

try:
yield sandbox
Expand Down