-
Notifications
You must be signed in to change notification settings - Fork 34
Chore: Clean-up unused/unecessary deps and add knip integration #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ben-fornefeld
wants to merge
9
commits into
main
Choose a base branch
from
clean-up-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused dependencies from package.json and bun.lock, including fumadocs packages and others. - Updated icon component props to remove unnecessary type imports, simplifying the code.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jakubno
requested changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. only nit - can you add knip
+ add it to the CI to keep it a good state in future?
- Added "knip" as a new dependency in bun.lock and package.json. - Updated "@napi-rs/wasm-runtime" and "@tybys/wasm-util" to their latest versions. - Added new optional dependencies for "oxc-resolver" bindings across various platforms. - Included "knip" commands in package.json for easier usage in development and production environments. - Ensured consistent formatting in package.json for better readability.
- Upgraded Bun setup action from v1 to v2. - Changed Bun version from 1.2.20 to 1.2.0. - Modified dependency installation command to use the frozen lockfile option. - Added a TODO comment to indicate the need for a proper integration test suite environment.
- Upgraded "@types/node" from "22.10.10" to "^24.6.0". - Updated "typescript" from "5.7.3" to "^5.9.2". - Added "knip" as a new dependency with version "^5.64.1". - Updated "@napi-rs/wasm-runtime" to "1.0.5" and "@tybys/wasm-util" to "0.10.1". - Included new optional dependencies for "oxc-resolver" bindings across various platforms.
there is a lot more unused code here, thanks @jakubno for pointing at knip! i will go through all of it and filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds Knip with CI integration, removes unused dependencies, updates Bun/TypeScript/tooling, and refactors imports to
server-only
andmotion/react
.knip.json
and GitHub workflow.github/workflows/dependencies.yml
to run Knip; addknip
scripts inpackage.json
.--frozen-lockfile
).fumadocs-*
,react-svg
,remark-*
/rehype-katex
,postgres
,drizzle-kit
, testing-library deps, others); addknip
; move/adjustpino-pretty
; bumptypescript
and@types/node
.bun.lock
accordingly.server-cli-only
withserver-only
in server modules and API routes; mockserver-only
in tests setup.framer-motion
usage tomotion/react
in client components.react-icons
type import).Written by Cursor Bugbot for commit a1f6b25. This will update automatically on new commits. Configure here.