Refactor: Sandbox monitoring performance improvements and clean up #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ring charts - Removed the legacy live updates lifecycle management and integrated live polling directly within the React component. - Updated chart components to utilize the new `setCustomRange` method for handling zoom events. - Enhanced performance by optimizing ECharts imports and configurations for better tree-shaking. - Adjusted opacity settings for live indicators to improve visual clarity. - Cleaned up unused code and improved overall readability of the chart components.
| } | ||
|
|
||
| return snapToAxis(max * scaleFactor) | ||
| } |
There was a problem hiding this comment.
Bug: Inconsistent Y-axis Scaling Due to Hardcoded Multiplier
The calculateYAxisMax function uses a hardcoded 1.1 multiplier for Y-axis max calculation when the data's maximum value exceeds the provided limit. This bypasses the configurable scaleFactor for padding in this specific scenario, leading to inconsistent Y-axis scaling behavior.
|
there is still one issue with polling lifecycle management when the tab is in background. investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Replaces legacy chart stack with a single ECharts-based team metrics chart and shared context, centralizes metrics fetching in a core API, and removes old chart/util code.
TeamMetricsChart(features/.../charts/team-metrics-chart/*) andTeamMetricsChartswrapper to render both concurrent and start-rate charts.TeamMetricsChartsProvider(charts-context.tsx) with SWR-driven data and timeframe state fromuseTimeframe.concurrent-chart.client.tsxandstart-rate-chart.client.tsxto useTeamMetricsChart, newcalculateCentralTendency, andtransformMetrics.TeamMetricsChartsinapp/dashboard/.../@monitoring/page.tsx.useTeamMetrics+ registry withuseTimeframe; manage live updates viauseEffectintimeframe-store.tsx.getTeamMetricsCore(overfetch, zero-fill, logging) and use it inapi/teams/[teamId]/metrics/route.tsandserver/sandboxes/get-team-metrics.ts.get-team-metrics-memo.use-header-metrics-swr.tsx) and header cards to use server-filled data; adjust 30‑day range usingMAX_DAYS_AGO.calculateCentralTendency,calculateYAxisMax(new params), andtransformMetrics.ui/charts/*,use-breakpoint.ts) and old utils (features/.../charts/utils.tsx,start-rate-chart.tsx).usage/chart-config.tsx(commonXAxisProps.interval).Written by Cursor Bugbot for commit e3c30be. This will update automatically on new commits. Configure here.
Completes ENG-3081