Skip to content

Conversation

djeebus
Copy link
Contributor

@djeebus djeebus commented Sep 26, 2025

Note

Refactors Hyperloop hosts update to safely rewrite /etc/hosts without dropping entries, adds newline-sensitive tests, and bumps version to 0.3.6.

  • Backend/API:
    • Hosts rewrite: Replace direct txeh file ops with rewriteHostsFile using RawText and explicit write to avoid dropped entries when missing trailing newline.
      • Ensures trailing newline, determines IP family via netip, no-ops if mapping unchanged, writes with 0o644 perms, and sets E2B_EVENTS_ADDRESS on success.
  • Tests:
    • Add TestSimpleCases covering various newline edge cases to verify stable hosts rewriting.
  • Version:
    • Bump envd version from 0.3.5 to 0.3.6.

Written by Cursor Bugbot for commit 183d6f3. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@jakubno jakubno self-assigned this Sep 30, 2025
cursor[bot]

This comment was marked as outdated.

@djeebus djeebus requested a review from jakubno September 30, 2025 19:03
djeebus and others added 2 commits October 6, 2025 09:53
in the future we might add some more functionality here.

Co-authored-by: Jakub Novák <[email protected]>
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@djeebus djeebus requested a review from jakubno October 6, 2025 19:35
# Conflicts:
#	packages/envd/internal/api/init.go
@ValentaTomas ValentaTomas removed their request for review October 7, 2025 05:07
jakubno
jakubno previously requested changes Oct 7, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it looks good

@djeebus djeebus requested a review from jakubno October 7, 2025 21:30
@djeebus djeebus changed the title Host file parsing fails without trailing newline Ensure that host file parsing doesn't drop entries when parsing. Oct 7, 2025
@djeebus djeebus dismissed jakubno’s stale review October 7, 2025 23:03

changes were implemented

Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing, can you increase envd versions 🙏🏻

@djeebus djeebus requested a review from jakubno October 8, 2025 16:04
jakubno
jakubno previously requested changes Oct 8, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you need to bump it one more time :D

cursor[bot]

This comment was marked as outdated.

@djeebus djeebus added the bug Something isn't working label Oct 8, 2025
@djeebus djeebus requested a review from jakubno October 8, 2025 16:26
@djeebus djeebus dismissed jakubno’s stale review October 8, 2025 16:27

envd version has been bumped (twice!)

@jakubno jakubno merged commit 39b8599 into main Oct 8, 2025
26 checks passed
@jakubno jakubno deleted the hosts branch October 8, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants