-
Notifications
You must be signed in to change notification settings - Fork 176
Ensure that host file parsing doesn't drop entries when parsing. #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # packages/envd/internal/api/init.go
in the future we might add some more functionality here. Co-authored-by: Jakub Novák <[email protected]>
# Conflicts: # packages/envd/internal/api/init.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing, can you increase envd versions 🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you need to bump it one more time :D
envd version has been bumped (twice!)
Note
Refactors Hyperloop hosts update to safely rewrite
/etc/hosts
without dropping entries, adds newline-sensitive tests, and bumps version to 0.3.6.txeh
file ops withrewriteHostsFile
usingRawText
and explicit write to avoid dropped entries when missing trailing newline.netip
, no-ops if mapping unchanged, writes with0o644
perms, and setsE2B_EVENTS_ADDRESS
on success.TestSimpleCases
covering various newline edge cases to verify stable hosts rewriting.envd
version from0.3.5
to0.3.6
.Written by Cursor Bugbot for commit 183d6f3. This will update automatically on new commits. Configure here.