Create config model for client-proxy #1296
Open
+194
−140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisite for supporting multiple orchestrators running on a single node.
Note
Introduce a typed env-based config and refactor logging, service discovery, pools, and main to use it (with ports as uint16) instead of raw env vars.
internal/cfg
withConfig
andServiceDiscoveryConfig
parsed viacaarlos0/env
(Parse
).SkipInitialOrchestratorReadinessCheck
.BuildServiceDiscoveryProvider(cfg, port)
; create provider constructors acceptingcfg.ServiceDiscoveryConfig
.ServiceDiscoveryItem.NodePort
and all SD ports touint16
; update DNS/K8s/Nomad/Static implementations.GetLogsQueryProvider(cfg)
andNewLokiQueryProvider(cfg)
; useconfig.LokiURL/User/Password
; addErrEmptyLokiURL
.handlers.NewStore
andedge.NewEdgeAPIStore
acceptcfg.Config
; useSkipInitialOrchestratorReadinessCheck
.uint16
.internal
getters and direct env reads.Uint16
fields.github.com/caarlos0/env/v11
and directtestify
dependency.internal/cfg/model_test.go
for basic parsing.Written by Cursor Bugbot for commit 5a7f2f3. This will update automatically on new commits. Configure here.