-
Notifications
You must be signed in to change notification settings - Fork 181
Add Secrets CRUD #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Secrets CRUD #1308
Conversation
043bf4f
to
5f1ac9f
Compare
My integration tests don’t really clean up after themselves, but it seems like the existing ones don’t either. Was that intentional, or just something that never got done? If it wasn’t intentional, I’ll add cleanup to my tests. @ValentaTomas |
Integration tests are executed on an environment that is cleaned after that, so there is no need for cleanup except if you are expecting that some messy tests can cause interference with other tests in the same run. |
WIP
This is still WIP and requires https://github.com/e2b-dev/belt/pull/200 to be merged and deployed.
Adds vault client + basic CRUD routes for secrets. Not integrated into hot path of sandbox create yet.
Still working on some observability stuff
Note
Adds Secrets CRUD API backed by HashiCorp Vault, including DB table/queries, feature flag/config, IaC wiring, and CI setup with a dev Vault.
GET/POST /secrets
,PATCH/DELETE /secrets/{secretID}
with validation (hostname allowlist, sizes) and feature flagsecrets-vault
.vault
client (AppRole auth, token renewal, KV v2 ops) and API config/env support:VAULT_ADDR
,VAULT_APPROLE_ROLE_ID
,VAULT_APPROLE_SECRET_ID
,VAULT_TLS_CA
.Secret
,NewSecret
,UpdateSecret
, routes registration; logging/metrics middleware includes/secrets
.public.secrets
table (RLS enabled) with indices; sqlc queries for create/get/update/delete.VAULT_ADDR
, AppRole creds (from GCP Secret Manager), andVAULT_TLS_CA
..github/actions/start-services/start-vault.sh
) integrated intostart-services
..env.template
adds Vault-related vars.github.com/hashicorp/vault-client-go
,go-retryablehttp
,go-secure-stdlib/strutil
,ryanuber/go-glob
and related sums.Written by Cursor Bugbot for commit 027e290. This will update automatically on new commits. Configure here.