Skip to content

Conversation

sitole
Copy link
Member

@sitole sitole commented Oct 7, 2025

  • Removed logic for DNS-based routing in client proxy
  • Removes DNS server with legacy Redis backup storage
  • Refactors use of sandbox routing catalog in api

Note

Removes DNS-based sandbox routing across API and client-proxy, replacing it with catalog-only resolution and cleaning up related config and dependencies.

  • Backend/API:
    • Remove internal DNS server (packages/api/internal/dns/server.go) and DNS wiring in orchestrator; use SandboxesCatalog for StoreSandbox/DeleteSandbox.
    • Replace dns field with routingCatalog; stop starting/closing DNS server.
    • Dependencies: drop direct github.com/go-redis/cache/v9 and github.com/miekg/dns; tidy indirects in go.mod/go.sum.
  • Client Proxy:
    • Eliminate DNS resolution; resolve sandboxes via catalog only in NewClientProxy and request handler.
    • Simplify NewClientProxy signature and usage; remove USE_CATALOG_RESOLUTION/USE_DNS_RESOLUTION env handling.
    • Remove DNS client logic and related imports.
  • IaC:
    • Remove USE_CATALOG_RESOLUTION and USE_DNS_RESOLUTION env vars from iac/provider-gcp/nomad/jobs/edge.hcl.

Written by Cursor Bugbot for commit 3d6e4ab. This will update automatically on new commits. Configure here.

@sitole sitole added the improvement Improvement for current functionality label Oct 7, 2025
Copy link

linear bot commented Oct 7, 2025

@sitole
Copy link
Member Author

sitole commented Oct 7, 2025

We can deploy this when all running sandboxes are registered in the Redis catalog.

Client proxy should be deployed first, so it will stop asking the DNS server if it is not found in the Redis catalog, but practically, the request will fail anyway, as it's not in the store, so a few milliseconds timeout will not be an issue here, and we can deploy in the same batch.

@sitole sitole force-pushed the chore/remove-dns-infrastructure-for-sandbox-routing-eng-3137 branch from a806625 to 1241738 Compare October 8, 2025 09:14
@sitole sitole marked this pull request as ready for review October 8, 2025 09:14
cursor[bot]

This comment was marked as outdated.

@sitole sitole force-pushed the chore/remove-dns-infrastructure-for-sandbox-routing-eng-3137 branch from 1241738 to 5ed59f7 Compare October 8, 2025 09:37
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno self-assigned this Oct 8, 2025
@sitole sitole force-pushed the chore/remove-dns-infrastructure-for-sandbox-routing-eng-3137 branch from 5ed59f7 to aa8e267 Compare October 9, 2025 12:42
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@sitole sitole requested a review from jakubno October 9, 2025 15:01
@sitole sitole force-pushed the chore/remove-dns-infrastructure-for-sandbox-routing-eng-3137 branch from aa8e267 to 2b74b3a Compare October 9, 2025 15:25
@jakubno jakubno merged commit c0af495 into main Oct 9, 2025
26 checks passed
@jakubno jakubno deleted the chore/remove-dns-infrastructure-for-sandbox-routing-eng-3137 branch October 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants