-
Notifications
You must be signed in to change notification settings - Fork 181
Remove dns infrastructure for sandbox routing #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dns infrastructure for sandbox routing #1313
Conversation
We can deploy this when all running sandboxes are registered in the Redis catalog. Client proxy should be deployed first, so it will stop asking the DNS server if it is not found in the Redis catalog, but practically, the request will fail anyway, as it's not in the store, so a few milliseconds timeout will not be an issue here, and we can deploy in the same batch. |
a806625
to
1241738
Compare
1241738
to
5ed59f7
Compare
5ed59f7
to
aa8e267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😊
aa8e267
to
2b74b3a
Compare
Note
Removes DNS-based sandbox routing across API and client-proxy, replacing it with catalog-only resolution and cleaning up related config and dependencies.
packages/api/internal/dns/server.go
) and DNS wiring in orchestrator; useSandboxesCatalog
forStoreSandbox
/DeleteSandbox
.dns
field withroutingCatalog
; stop starting/closing DNS server.github.com/go-redis/cache/v9
andgithub.com/miekg/dns
; tidy indirects ingo.mod
/go.sum
.NewClientProxy
and request handler.NewClientProxy
signature and usage; removeUSE_CATALOG_RESOLUTION
/USE_DNS_RESOLUTION
env handling.USE_CATALOG_RESOLUTION
andUSE_DNS_RESOLUTION
env vars fromiac/provider-gcp/nomad/jobs/edge.hcl
.Written by Cursor Bugbot for commit 3d6e4ab. This will update automatically on new commits. Configure here.